Issue 15957005: Extract common sampling code into SampleHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15957005: Extract common sampling code into SampleHelper (Closed)

Created:
7 years, 6 months ago by yurys

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne, loislo, alph, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Simulator specific code that is the same on all platforms as well as TickSample instance retrieval extracted into SampleHelper class. Drive-by: extracted platform-independent pieces of Sampler::PlatformData into PlatformDataCommon. BUG=None R=loislo@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14910

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+131 lines, -135 lines)			Patch
	M	src/sampler.cc	View	1 2	6 chunks	+131 lines, -135 lines	0 comments	Download

Total messages: 4 (0 generated)

yurys

7 years, 6 months ago (2013-06-03 07:52:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r14910 (presubmit successful).