Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: components/startup_metric_utils/common/pre_read_field_trial_utils_win.h

Issue 1595633002: Use valid /prefetch arguments for process launches on Windows. - do not submit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move
Patch Set: address simple comments from gab Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/startup_metric_utils/common/pre_read_field_trial_utils_win.h
diff --git a/components/startup_metric_utils/common/pre_read_field_trial_utils_win.h b/components/startup_metric_utils/common/pre_read_field_trial_utils_win.h
index 612f76b2f43d39cc88436d2e7948ca2b9e11600b..3051dc29171066a312977e70bb750c1bf5945b8f 100644
--- a/components/startup_metric_utils/common/pre_read_field_trial_utils_win.h
+++ b/components/startup_metric_utils/common/pre_read_field_trial_utils_win.h
@@ -19,19 +19,27 @@ namespace startup_metric_utils {
using RegisterPreReadSyntheticFieldTrialCallback =
const base::Callback<bool(const std::string&, const std::string&)>;
-// Get DLL pre-reading options. |product_registry_path| is the registry path
-// under which the registry key for this field trial resides. The |no_pre_read|
-// option is set if DLLs should not be pre-read. The |high_priority| option is
-// set if pre-reading should be done with a high thread priority. The
-// |only_if_cold| option is set if only cold DLLs should be pre-read. The
-// |prefetch_virtual_memory| option is set if the
-// ::PrefetchVirtualMemory function should be used to pre-read DLLs, if
-// available.
-void GetPreReadOptions(const base::string16& product_registry_path,
- bool* no_pre_read,
- bool* high_priority,
- bool* only_if_cold,
- bool* prefetch_virtual_memory);
+// The options controlled by the PreRead field trial.
+enum PreReadOptions {
+ // No explicit DLL pre-reading.
+ NO_PRE_READ = 1 << 0,
+
+ // Pre-read DLLs with a high thread priority.
+ HIGH_PRIORITY = 1 << 1,
+
+ // Pre-read DLLs only when they are cold.
+ ONLY_IF_COLD = 1 << 2,
+
+ // Pre-read DLLs using the ::PrefetchVirtualMemory function, if available.
+ PREFETCH_VIRTUAL_MEMORY = 1 << 3,
+
+ // Do not launch processes with a valid /prefetch argument.
+ NO_PREFETCH_ARGUMENT = 1 << 4,
+};
+
+// Returns DLL pre-reading options. |product_registry_path| is the
+// registry path under which the registry key for this field trial resides.
+int GetPreReadOptions(const base::string16& product_registry_path);
// Updates DLL pre-reading options in the registry with the latest info for the
// next startup. |product_registry_path| is the registry path under which the

Powered by Google App Engine
This is Rietveld 408576698