chrome/app/main_dll_loader_win.cc - Issue 1595633002: Use valid /prefetch arguments for process launches on Windows. - do not submit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/main_dll_loader_win.cc

Issue 1595633002: Use valid /prefetch arguments for process launches on Windows. - do not submit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move

Patch Set: format Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/main_dll_loader_win.cc

diff --git a/chrome/app/main_dll_loader_win.cc b/chrome/app/main_dll_loader_win.cc

index a70a6787d1504d0f2ce48b52ae09ce9325ac2f9b..2ed2dc21c4035c0b2e9417cadb49c5622cdef119 100644

--- a/chrome/app/main_dll_loader_win.cc

+++ b/chrome/app/main_dll_loader_win.cc

@@ -68,10 +68,11 @@ HMODULE LoadModuleWithDirectory(const base::FilePath& module) {

bool trial_high_priority = false;

bool trial_only_if_cold = false;

bool trial_prefetch_virtual_memory = false;

+ bool ignored;

startup_metric_utils::GetPreReadOptions(

BrowserDistribution::GetDistribution()->GetRegistryPath(),

&trial_no_pre_read, &trial_high_priority, &trial_only_if_cold,

- &trial_prefetch_virtual_memory);

+ &trial_prefetch_virtual_memory, &ignored);

// Pre-read the binary to warm the memory caches (avoids a lot of random IO).

if (!trial_no_pre_read) {

« no previous file with comments | « chrome/app/chrome_watcher_command_line_win.cc ('k') | chrome/browser/browser_process_impl.cc » ('j') | chrome/browser/browser_process_impl.cc » ('J')