Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1595593002: PPC: [runtime] Throw exception for derived constructors in correct context. (Closed)

Created:
4 years, 11 months ago by MTBrandyberry
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [runtime] Throw exception for derived constructors in correct context. Port c86f1897ac52f2cae088d6cab8843216bdaa9396 Original commit message: When derived constructors return a non-object (or not undefined) we currently throw an exception directly in the callee context. This was achieved by desugaring the return statement for derived classes. To be spec compliamnt a separate ConstructStubForDerived is introduced. Instead of trowing directly, the desugared return statement inside a derived constructor only returns an integer to indicate an incompatible result. R=cbruni@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4509 LOG=n Committed: https://crrev.com/bbb95fba40817494752bbd231260b38ab7277aaf Cr-Commit-Position: refs/heads/master@{#33341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M src/ppc/builtins-ppc.cc View 3 chunks +19 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
4 years, 11 months ago (2016-01-15 17:58:11 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1595593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1595593002/1
4 years, 11 months ago (2016-01-15 18:16:04 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-15 18:38:16 UTC) #5
john.yan
lgtm
4 years, 11 months ago (2016-01-15 19:01:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1595593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1595593002/1
4 years, 11 months ago (2016-01-15 19:03:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 19:04:32 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 19:05:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbb95fba40817494752bbd231260b38ab7277aaf
Cr-Commit-Position: refs/heads/master@{#33341}

Powered by Google App Engine
This is Rietveld 408576698