Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1595553004: Better performance on long lists containing comments. (Closed)

Created:
4 years, 11 months ago by Bob Nystrom
Modified:
4 years, 11 months ago
Reviewers:
tjblasi
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Better performance on long lists containing comments. Fix #484. R=tjblasi@google.com Committed: https://github.com/dart-lang/dart_style/commit/656695eccde43af07011f9f808baf2c019124a0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -10 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M bin/format.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/chunk_builder.dart View 1 chunk +5 lines, -1 line 0 comments Download
M lib/src/source_visitor.dart View 1 chunk +24 lines, -7 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
A test/regression/0400/0484.stmt View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Bob Nystrom
4 years, 11 months ago (2016-01-16 00:26:05 UTC) #2
Bob Nystrom
4 years, 11 months ago (2016-01-16 00:32:42 UTC) #4
tjblasi
lgtm
4 years, 11 months ago (2016-01-16 00:39:04 UTC) #5
Bob Nystrom
4 years, 11 months ago (2016-01-16 00:50:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
656695eccde43af07011f9f808baf2c019124a0d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698