Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: extensions/common/manifest_handlers/kiosk_mode_info_unittest.cc

Issue 1595483004: kiosk: Add kiosk.required_platform_version manifest key (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: put required_platform_version under kiosk and target dev channel Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest_handlers/kiosk_mode_info_unittest.cc
diff --git a/extensions/common/manifest_handlers/kiosk_mode_info_unittest.cc b/extensions/common/manifest_handlers/kiosk_mode_info_unittest.cc
index 9e42c1899d2560245d621b2dfac29b4eb5e30815..444af6380b735f14407db184f9bb195c56872362 100644
--- a/extensions/common/manifest_handlers/kiosk_mode_info_unittest.cc
+++ b/extensions/common/manifest_handlers/kiosk_mode_info_unittest.cc
@@ -32,4 +32,25 @@ TEST_F(KioskModeInfoManifestTest, MultipleSecondaryApps) {
std::equal(parsed_ids.begin(), parsed_ids.end(), expected_ids));
}
+TEST_F(KioskModeInfoManifestTest, RequiredPlatformVersionOptional) {
+ scoped_refptr<Extension> extension(
+ LoadAndExpectSuccess("kiosk_required_platform_version_not_present.json"));
+ KioskModeInfo* info = KioskModeInfo::Get(extension.get());
+ EXPECT_TRUE(info->required_platform_version.empty());
+}
+
+TEST_F(KioskModeInfoManifestTest, RequiredPlatformVersion) {
+ scoped_refptr<Extension> extension(
+ LoadAndExpectSuccess("kiosk_required_platform_version.json"));
+ KioskModeInfo* info = KioskModeInfo::Get(extension.get());
+ EXPECT_EQ("1234.0.0", info->required_platform_version);
+}
+
+TEST_F(KioskModeInfoManifestTest, RequiredPlatformVersionInvalid) {
+ LoadAndExpectError("kiosk_required_platform_version_empty.json",
+ manifest_errors::kInvalidKioskRequiredPlatformVersion);
+ LoadAndExpectError("kiosk_required_platform_version_invalid.json",
+ manifest_errors::kInvalidKioskRequiredPlatformVersion);
+}
+
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698