Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1595403003: [regexp] fix interpreted irregexp build. (Closed)

Created:
4 years, 11 months ago by Yang
Modified:
4 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] fix interpreted irregexp build. R=jkummerow@chromium.org Committed: https://crrev.com/085487dd03e7524a919d2d272cba657dc864bc50 Cr-Commit-Position: refs/heads/master@{#33354}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/regexp/regexp-macro-assembler-irregexp.h View 1 chunk +6 lines, -0 lines 0 comments Download
M test/webkit/webkit.status View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1574113009 Patch 1

Messages

Total messages: 7 (2 generated)
Yang
4 years, 11 months ago (2016-01-18 10:12:09 UTC) #1
Jakob Kummerow
lgtm
4 years, 11 months ago (2016-01-18 10:20:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1595403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1595403003/1
4 years, 11 months ago (2016-01-18 10:22:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-18 10:41:29 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 10:42:18 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/085487dd03e7524a919d2d272cba657dc864bc50
Cr-Commit-Position: refs/heads/master@{#33354}

Powered by Google App Engine
This is Rietveld 408576698