Refactoring of master preferences parsing before adding a new preference.

Refactoring of master preferences parsing before adding a new preference.

Currently we are parsing master preferences file three time on startup. Since we only return an int bit mask flag after parsing preferences, it can not handle any preference other than boolean and we end up reading it again for first run tabs and ping delay. This change refactors all the preferences parsing logic to directly pass around DictionaryValue object around in Chrome as well as installer.

No functional change but this will make adding a new preference for new icon more logical since we will not read the preferences file once again.


BUG=12701
TEST=Make sure all the distribution preferences still work as before.

Committed: http://src.chromium.org/viewvc/22284

[cpu_(ooo_6.6-7.5), 2009-07-31 19:55:11]

LGTM

some nits below.

http://codereview.chromium.org/159539/diff/1032/46
File chrome/browser/browser_main.cc (right):

http://codereview.chromium.org/159539/diff/1032/46#newcode445
Line 445: int ping_delay = 0;
in the context of  main, "ping_delay" seems too obscure, it should be
rlz_ping_delay.

http://codereview.chromium.org/159539/diff/1032/50
File chrome/installer/setup/install.cc (right):

http://codereview.chromium.org/159539/diff/1032/50#newcode6
Line 6: #include <time.h>
you removed <windows.h> from the header, do you want to add it back here?