src/core/SkBitmap.cpp - Issue 159533002: fix test for empty config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkBitmap.cpp

Issue 159533002: fix test for empty config (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkBitmap.cpp

diff --git a/src/core/SkBitmap.cpp b/src/core/SkBitmap.cpp

index e76ee02284c0163d4c982d9d0f01dc82f712a4e8..96d683c0e2592765351bcf5e9912085b660093a6 100644

--- a/src/core/SkBitmap.cpp

+++ b/src/core/SkBitmap.cpp

@@ -263,7 +263,7 @@ bool SkBitmap::setConfig(const SkImageInfo& info, size_t rowBytes) {

return reset_return_false(this);

}

- if (info.isEmpty()) {

+ if (info.width() < 0 || info.height() < 0) {

return reset_return_false(this);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »