Move AST implementation out of generated

Move AST implementation out of generated

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/539f0dff4ab9523c48b0ac51c63304c68c33eaab

[Brian Wilkerson, 2016-01-18 19:18:55]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com, scheglov@google.com

[Brian Wilkerson, 2016-01-18 19:18:56]

Import clean-up to follow.

[scheglov, 2016-01-18 19:52:31]

LGTM

https://codereview.chromium.org/1595243003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/ast.dart (right):

https://codereview.chromium.org/1595243003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/ast.dart:15: library analyzer.src.generated.ast;
Maybe @deprecated also?
Or this will cause hints and analysis failures of the clients?

[Brian Wilkerson, 2016-01-18 21:00:50]

https://codereview.chromium.org/1595243003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/ast.dart (right):

https://codereview.chromium.org/1595243003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/ast.dart:15: library analyzer.src.generated.ast;
> Or this will cause hints and analysis failures of the clients?

It would cause hints, both in client code and in our code (because I haven't
cleaned up imports in our code yet). At some point we should do so, however, so
that clients are informed about the need to update.

[Brian Wilkerson, 2016-01-18 21:02:08]

Description was changed from

==========
Move AST implementation out of generated
==========

to

==========
Move AST implementation out of generated

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/539f0dff4ab9523c48b0ac51c63304c68c33eaab
==========

[Brian Wilkerson, 2016-01-18 21:02:09]

Committed patchset #1 (id:1) manually as
539f0dff4ab9523c48b0ac51c63304c68c33eaab (presubmit successful).

[skybrian, 2016-01-20 00:57:14]

On 2016/01/18 21:02:09, Brian Wilkerson wrote:
> Committed patchset #1 (id:1) manually as
> 539f0dff4ab9523c48b0ac51c63304c68c33eaab (presubmit successful).

This is great, but ast.dart is still a 10k+ line file. Any thoughts on splitting
it up?

Or maybe remove most of the comments on the fields? Some of them look redundant.

  /**
   * The left parenthesis.
   */
  Token leftParenthesis;