Issue 159523003: More instrumentation for GDI allocation failures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159523003: More instrumentation for GDI allocation failures (Closed)

Created:
6 years, 10 months ago by cpu_(ooo_6.6-7.5)

Modified:
6 years, 10 months ago

Reviewers:
jamesr, brettw, (unused - use chromium)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

More instrumentation for GDI allocation failures The problem is that ::CreateDIBSection fails and we don't know why the current instrumentation tells us that everything is nice in the current process, so we are adding code to check on the child processes of the current process. Its a big crasher in dev soon to be beta so I am rushing this. TBR=brettw,jamesr,thakis BUG=341593 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250357

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+160 lines, -54 lines)			Patch
M	base/base.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	base/debug/gdi_debug_util_win.h	View	1 chunk	+23 lines, -0 lines	0 comments	Download
A	base/debug/gdi_debug_util_win.cc	View	1 chunk	+129 lines, -0 lines	0 comments	Download
M	skia/ext/bitmap_platform_device_win.cc	View	2 chunks	+6 lines, -54 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/159523003/1

6 years, 10 months ago (2014-02-11 03:26:53 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages