Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: test/cctest/interpreter/test-interpreter.cc

Issue 1595223004: [Interpreter] Change ignition fallback flag to only fallback on catch, not eval. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/interpreter/test-bytecode-generator.cc ('k') | test/mjsunit/mjsunit.status » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/execution.h" 7 #include "src/execution.h"
8 #include "src/handles.h" 8 #include "src/handles.h"
9 #include "src/interpreter/bytecode-array-builder.h" 9 #include "src/interpreter/bytecode-array-builder.h"
10 #include "src/interpreter/interpreter.h" 10 #include "src/interpreter/interpreter.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 InterpreterTester(Isolate* isolate, const char* source, 59 InterpreterTester(Isolate* isolate, const char* source,
60 MaybeHandle<BytecodeArray> bytecode, 60 MaybeHandle<BytecodeArray> bytecode,
61 MaybeHandle<TypeFeedbackVector> feedback_vector, 61 MaybeHandle<TypeFeedbackVector> feedback_vector,
62 const char* filter) 62 const char* filter)
63 : isolate_(isolate), 63 : isolate_(isolate),
64 source_(source), 64 source_(source),
65 bytecode_(bytecode), 65 bytecode_(bytecode),
66 feedback_vector_(feedback_vector) { 66 feedback_vector_(feedback_vector) {
67 i::FLAG_ignition = true; 67 i::FLAG_ignition = true;
68 i::FLAG_ignition_fake_try_catch = true; 68 i::FLAG_ignition_fake_try_catch = true;
69 i::FLAG_ignition_fallback_on_eval_and_catch = false; 69 i::FLAG_ignition_fallback_on_catch = false;
70 i::FLAG_always_opt = false; 70 i::FLAG_always_opt = false;
71 // Set ignition filter flag via SetFlagsFromString to avoid double-free 71 // Set ignition filter flag via SetFlagsFromString to avoid double-free
72 // (or potential leak with StrDup() based on ownership confusion). 72 // (or potential leak with StrDup() based on ownership confusion).
73 ScopedVector<char> ignition_filter(64); 73 ScopedVector<char> ignition_filter(64);
74 SNPrintF(ignition_filter, "--ignition-filter=%s", filter); 74 SNPrintF(ignition_filter, "--ignition-filter=%s", filter);
75 FlagList::SetFlagsFromString(ignition_filter.start(), 75 FlagList::SetFlagsFromString(ignition_filter.start(),
76 ignition_filter.length()); 76 ignition_filter.length());
77 // Ensure handler table is generated. 77 // Ensure handler table is generated.
78 isolate->interpreter()->Initialize(); 78 isolate->interpreter()->Initialize();
79 } 79 }
(...skipping 3553 matching lines...) Expand 10 before | Expand all | Expand 10 after
3633 auto callable = tester.GetCallable<>(); 3633 auto callable = tester.GetCallable<>();
3634 3634
3635 Handle<i::Object> return_value = callable().ToHandleChecked(); 3635 Handle<i::Object> return_value = callable().ToHandleChecked();
3636 CHECK(return_value->SameValue(*eval_func_decl[i].second)); 3636 CHECK(return_value->SameValue(*eval_func_decl[i].second));
3637 } 3637 }
3638 } 3638 }
3639 3639
3640 } // namespace interpreter 3640 } // namespace interpreter
3641 } // namespace internal 3641 } // namespace internal
3642 } // namespace v8 3642 } // namespace v8
OLDNEW
« no previous file with comments | « test/cctest/interpreter/test-bytecode-generator.cc ('k') | test/mjsunit/mjsunit.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698