Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1595223004: [Interpreter] Change ignition fallback flag to only fallback on catch, not eval. (Closed)

Created:
4 years, 11 months ago by rmcilroy
Modified:
4 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, Michael Hablich, mythria
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Change ignition fallback flag to only fallback on catch, not eval. Now that we support eval in Ignition, remove the fallback for eval checks and make the flag only fallback on catch blocks. BUG=v8:4280, v8:4676 LOG=N Committed: https://crrev.com/43c02e49d89f33dc9ae4d8f5c3073d1cb8bdf640 Cr-Commit-Position: refs/heads/master@{#33384}

Patch Set 1 #

Patch Set 2 : Add two Arm64 specific skips #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -15 lines) Patch
M src/compiler.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -3 lines 0 comments Download
M test/cctest/cctest.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 18 chunks +31 lines, -4 lines 0 comments Download
M test/test262/test262.status View 3 chunks +3 lines, -0 lines 0 comments Download
M tools/testrunner/local/testsuite.py View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1595223004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1595223004/1
4 years, 11 months ago (2016-01-18 16:46:18 UTC) #2
rmcilroy
PTAL, thanks. Maybe we can remove the whole flag by the end of the week ...
4 years, 11 months ago (2016-01-18 16:47:03 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/14109)
4 years, 11 months ago (2016-01-18 17:07:18 UTC) #6
Michael Starzinger
LGTM. (Almost) nothing can stop us now. :)
4 years, 11 months ago (2016-01-18 17:09:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1595223004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1595223004/20001
4 years, 11 months ago (2016-01-19 11:03:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/12503) v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, ...
4 years, 11 months ago (2016-01-19 11:04:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1595223004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1595223004/40001
4 years, 11 months ago (2016-01-19 11:08:04 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-19 11:33:26 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 11:33:59 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/43c02e49d89f33dc9ae4d8f5c3073d1cb8bdf640
Cr-Commit-Position: refs/heads/master@{#33384}

Powered by Google App Engine
This is Rietveld 408576698