[chromium-reviews] Fix for spell check underlines disappearing when user clicks out of the Text ...

webkit/glue/editor_client_impl.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The Mac interface forwards most of these commands to the application layer,
 // and I'm not really sure what to do about most of them.
 
 #include "config.h"
 #include "webkit/glue/editor_client_impl.h"
 
@@ skipping 112 matching lines @@
   const WebCore::Frame* frame = web_view_->GetFocusedWebCoreFrame();
   if (!frame)
     return false;
   const WebCore::Editor* editor = frame->editor();
   if (!editor)
     return false;
   const WebCore::Document* document = frame->document();
   if (!document)
     return false;
   const WebCore::Node* node = document->focusedNode();
+  // If |node| is NULL, we default to allowing spellchecking. This is done in
+  // order to mitigate the issue when the user clicks outside the textbox, as a
+  // result of which |node| becomes NULL, resulting in all the spell check
+  // markers being deleted. Also, the Frame will decide not to do spellchecking
+  // if the user can't edit - so returning true here will not cause any problems
+  // to the Frame's behavior.
   if (!node)
-    return false;
+    return true;
   const WebCore::RenderObject* renderer = node->renderer();
   if (!renderer)
     return false;
 
-  return (!renderer->isTextField() && editor->canEdit());
+  return !renderer->isTextField();
 }
 
 bool EditorClientImpl::isContinuousSpellCheckingEnabled() {
   if (spell_check_this_field_status_ == SPELLCHECK_FORCED_OFF)
     return false;
   else if (spell_check_this_field_status_ == SPELLCHECK_FORCED_ON)
     return true;
   else
     return ShouldSpellcheckByDefault();
 }
@@ skipping 860 matching lines @@
   }
   return L"(UNKNOWN AFFINITY)";
 }
 
 std::wstring EditorClientImpl::Describe(WebCore::CSSStyleDeclaration* style) {
   // TODO(pamg): Implement me.  It's not clear what WebKit produces for this
   // (their [style description] method), and none of the layout tests provide
   // an example.  But because none of them use it, it's not yet important.
   return std::wstring();
 }