Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/a64/lithium-codegen-a64.cc

Issue 159513004: Port of r19288 to a64: Fix for smi stores optimization. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5085 matching lines...) Expand 10 before | Expand all | Expand 10 after
5096 if (access.IsInobject()) { 5096 if (access.IsInobject()) {
5097 destination = object; 5097 destination = object;
5098 } else { 5098 } else {
5099 __ Ldr(temp0, FieldMemOperand(object, JSObject::kPropertiesOffset)); 5099 __ Ldr(temp0, FieldMemOperand(object, JSObject::kPropertiesOffset));
5100 destination = temp0; 5100 destination = temp0;
5101 } 5101 }
5102 5102
5103 if (representation.IsSmi() && 5103 if (representation.IsSmi() &&
5104 instr->hydrogen()->value()->representation().IsInteger32()) { 5104 instr->hydrogen()->value()->representation().IsInteger32()) {
5105 ASSERT(instr->hydrogen()->store_mode() == STORE_TO_INITIALIZED_ENTRY); 5105 ASSERT(instr->hydrogen()->store_mode() == STORE_TO_INITIALIZED_ENTRY);
5106 #ifdef DEBUG
5107 __ Ldr(temp1, FieldMemOperand(destination, offset));
5108 __ AssertSmi(temp1);
5109 #endif
5106 STATIC_ASSERT(kSmiValueSize == 32 && kSmiShift == 32 && kSmiTag == 0); 5110 STATIC_ASSERT(kSmiValueSize == 32 && kSmiShift == 32 && kSmiTag == 0);
5107 __ Store(value, UntagSmiFieldMemOperand(destination, offset), 5111 __ Store(value, UntagSmiFieldMemOperand(destination, offset),
5108 Representation::Integer32()); 5112 Representation::Integer32());
5109 } else { 5113 } else {
5110 __ Store(value, FieldMemOperand(destination, offset), representation); 5114 __ Store(value, FieldMemOperand(destination, offset), representation);
5111 } 5115 }
5112 if (instr->hydrogen()->NeedsWriteBarrier()) { 5116 if (instr->hydrogen()->NeedsWriteBarrier()) {
5113 __ RecordWriteField(destination, 5117 __ RecordWriteField(destination,
5114 offset, 5118 offset,
5115 value, // Clobbered. 5119 value, // Clobbered.
(...skipping 581 matching lines...) Expand 10 before | Expand all | Expand 10 after
5697 __ Bind(&out_of_object); 5701 __ Bind(&out_of_object);
5698 __ Ldr(result, FieldMemOperand(object, JSObject::kPropertiesOffset)); 5702 __ Ldr(result, FieldMemOperand(object, JSObject::kPropertiesOffset));
5699 // Index is equal to negated out of object property index plus 1. 5703 // Index is equal to negated out of object property index plus 1.
5700 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2)); 5704 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2));
5701 __ Ldr(result, FieldMemOperand(result, 5705 __ Ldr(result, FieldMemOperand(result,
5702 FixedArray::kHeaderSize - kPointerSize)); 5706 FixedArray::kHeaderSize - kPointerSize));
5703 __ Bind(&done); 5707 __ Bind(&done);
5704 } 5708 }
5705 5709
5706 } } // namespace v8::internal 5710 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698