SyncFS: Factor out DriveMetadataDB migration functions

chrome/browser/sync_file_system/drive/metadata_db_migration_util_unittest.cc

Index: chrome/browser/sync_file_system/drive/metadata_db_migration_util_unittest.cc
diff --git a/chrome/browser/sync_file_system/drive/metadata_db_migration_util_unittest.cc b/chrome/browser/sync_file_system/drive/metadata_db_migration_util_unittest.cc
index e37361cd6e81d3c515df1e7cf1b41143e774d79e..3c7daf43a321a7229e5a2968e4a03ca82c306b38 100644
--- a/chrome/browser/sync_file_system/drive/metadata_db_migration_util_unittest.cc
+++ b/chrome/browser/sync_file_system/drive/metadata_db_migration_util_unittest.cc
@@ -20,6 +20,31 @@
 namespace sync_file_system {
 namespace drive {
 
+namespace {
+const char kV0ServiceName[] = "drive";
+}
+
+TEST(DriveMetadataDBMigrationUtilTest, ParseV0FormatFileSystemURL) {
+  const GURL kOrigin("chrome-extension://example");
+  const base::FilePath kFile(FPL("foo bar"));
+
+  ASSERT_TRUE(RegisterSyncableFileSystem(kV0ServiceName));
+
+  fileapi::FileSystemURL url =
+      CreateSyncableFileSystemURL(kOrigin, kV0ServiceName, kFile);
+
+  std::string serialized_url;
+  SerializeSyncableFileSystemURL(url, &serialized_url);
+
+  GURL origin;
+  base::FilePath path;
+  EXPECT_TRUE(ParseV0FormatFileSystemURL(GURL(serialized_url), &origin, &path));
+  EXPECT_EQ(kOrigin, origin);
+  EXPECT_EQ(kFile, path);
+
+  EXPECT_TRUE(RevokeSyncableFileSystem(kV0ServiceName));
+}
+
 TEST(DriveMetadataDBMigrationUtilTest, AddWapiIdPrefix) {
   DriveMetadata_ResourceType type_file =
       DriveMetadata_ResourceType_RESOURCE_TYPE_FILE;
@@ -46,26 +71,136 @@ TEST(DriveMetadataDBMigrationUtilTest, RemoveWapiIdPrefix) {
   EXPECT_EQ("foo:xxx", RemoveWapiIdPrefix("foo:xxx"));
 }
 
+TEST(DriveMetadataDBMigrationUtilTest, MigrationFromV0) {
+  const char kDatabaseVersionKey[] = "VERSION";
+  const char kChangeStampKey[] = "CHANGE_STAMP";
+  const char kSyncRootDirectoryKey[] = "SYNC_ROOT_DIR";
+  const char kDriveMetadataKeyPrefix[] = "METADATA: ";
+  const char kDriveBatchSyncOriginKeyPrefix[] = "BSYNC_ORIGIN: ";
+  const char kDriveIncrementalSyncOriginKeyPrefix[] = "ISYNC_ORIGIN: ";
+
+  const GURL kOrigin1("chrome-extension://example1");
+  const GURL kOrigin2("chrome-extension://example2");
+  const std::string kSyncRootResourceId("folder:sync_root_resource_id");
+  const std::string kResourceId1("folder:hoge");
+  const std::string kResourceId2("folder:fuga");
+  const std::string kFileResourceId("file:piyo");
+  const base::FilePath kFile(FPL("foo bar"));
+  const std::string kFileMD5("file_md5");
+
+  ASSERT_TRUE(RegisterSyncableFileSystem(kV0ServiceName));
+
+  base::ScopedTempDir base_dir;
+  ASSERT_TRUE(base_dir.CreateUniqueTempDir());
+
+  leveldb::Options options;
+  options.create_if_missing = true;
+  leveldb::DB* db_ptr = NULL;
+  std::string db_dir = fileapi::FilePathToString(
+      base_dir.path().Append(DriveMetadataStore::kDatabaseName));
+  leveldb::Status status = leveldb::DB::Open(options, db_dir, &db_ptr);
+
+  scoped_ptr<leveldb::DB> db(db_ptr);
+  ASSERT_TRUE(status.ok());
+
+  // Setup the database with the schema version 0.
+  leveldb::WriteBatch batch;
+  batch.Put(kChangeStampKey, "1");
+  batch.Put(kSyncRootDirectoryKey, kSyncRootResourceId);
+
+  fileapi::FileSystemURL url =
+      CreateSyncableFileSystemURL(kOrigin1, kV0ServiceName, kFile);
+
+  // Setup drive metadata.
+  DriveMetadata drive_metadata;
+  drive_metadata.set_resource_id(kFileResourceId);
+  drive_metadata.set_md5_checksum(kFileMD5);
+  drive_metadata.set_conflicted(false);
+  drive_metadata.set_to_be_fetched(false);
+
+  std::string serialized_url;
+  SerializeSyncableFileSystemURL(url, &serialized_url);
+  std::string metadata_string;
+  drive_metadata.SerializeToString(&metadata_string);
+  batch.Put(kDriveMetadataKeyPrefix + serialized_url, metadata_string);
+
+  // Setup batch sync origin and incremental sync origin.
+  batch.Put(kDriveBatchSyncOriginKeyPrefix + kOrigin1.spec(), kResourceId1);
+  batch.Put(kDriveIncrementalSyncOriginKeyPrefix + kOrigin2.spec(),
+            kResourceId2);
+
+  status = db->Write(leveldb::WriteOptions(), &batch);
+  EXPECT_EQ(SYNC_STATUS_OK, LevelDBStatusToSyncStatusCode(status));
+  EXPECT_TRUE(RevokeSyncableFileSystem(kV0ServiceName));
+
+  // Migrate the database.
+  drive::MigrateDatabaseFromV0ToV1(db.get());
+
+  scoped_ptr<leveldb::Iterator> itr(db->NewIterator(leveldb::ReadOptions()));
+
+  // Verify DB schema version.
+  int64 database_version = 0;
+  itr->Seek(kDatabaseVersionKey);
+  EXPECT_TRUE(itr->Valid());
+  EXPECT_TRUE(base::StringToInt64(itr->value().ToString(), &database_version));
+  EXPECT_EQ(1, database_version);
+
+  // Verify the largest changestamp.
+  int64 changestamp = 0;
+  itr->Seek(kChangeStampKey);
+  EXPECT_TRUE(itr->Valid());
+  EXPECT_TRUE(base::StringToInt64(itr->value().ToString(), &changestamp));
+  EXPECT_EQ(1, changestamp);
+
+  // Verify the sync root directory.
+  itr->Seek(kSyncRootDirectoryKey);
+  EXPECT_TRUE(itr->Valid());
+  EXPECT_EQ(kSyncRootResourceId, itr->value().ToString());
+
+  // Verify the metadata.
+  itr->Seek(kDriveMetadataKeyPrefix);
+  EXPECT_TRUE(itr->Valid());
+  DriveMetadata metadata;
+  EXPECT_TRUE(metadata.ParseFromString(itr->value().ToString()));
+  EXPECT_EQ(kFileResourceId, metadata.resource_id());
+  EXPECT_EQ(kFileMD5, metadata.md5_checksum());
+  EXPECT_FALSE(metadata.conflicted());
+  EXPECT_FALSE(metadata.to_be_fetched());
+
+  // Verify the batch sync origin.
+  itr->Seek(kDriveBatchSyncOriginKeyPrefix);
+  EXPECT_TRUE(itr->Valid());
+  EXPECT_EQ(kResourceId1, itr->value().ToString());
+
+  // Verify the incremental sync origin.
+  itr->Seek(kDriveIncrementalSyncOriginKeyPrefix);
+  EXPECT_TRUE(itr->Valid());
+  EXPECT_EQ(kResourceId2, itr->value().ToString());
+}
+
 TEST(DriveMetadataDBMigrationUtilTest, MigrationFromV1) {
   const char kDatabaseVersionKey[] = "VERSION";
   const char kChangeStampKey[] = "CHANGE_STAMP";
   const char kSyncRootDirectoryKey[] = "SYNC_ROOT_DIR";
   const char kDriveMetadataKeyPrefix[] = "METADATA: ";
   const char kMetadataKeySeparator = ' ';
+  const char kDriveBatchSyncOriginKeyPrefix[] = "BSYNC_ORIGIN: ";
   const char kDriveIncrementalSyncOriginKeyPrefix[] = "ISYNC_ORIGIN: ";
   const char kDriveDisabledOriginKeyPrefix[] = "DISABLED_ORIGIN: ";
 
   const GURL kOrigin1("chrome-extension://example1");
   const GURL kOrigin2("chrome-extension://example2");
+  const GURL kOrigin3("chrome-extension://example3");
 
   const std::string kSyncRootResourceId("folder:sync_root_resource_id");
   const std::string kResourceId1("folder:hoge");
   const std::string kResourceId2("folder:fuga");
+  const std::string kResourceId3("folder:hogera");
   const std::string kFileResourceId("file:piyo");
   const base::FilePath kFile(FPL("foo bar"));
   const std::string kFileMD5("file_md5");
 
-  const char kV1ServiceName[] = "drive";
+  const char kV1ServiceName[] = "syncfs";
   ASSERT_TRUE(RegisterSyncableFileSystem(kV1ServiceName));
 
   base::ScopedTempDir base_dir;
@@ -81,7 +216,7 @@ TEST(DriveMetadataDBMigrationUtilTest, MigrationFromV1) {
   scoped_ptr<leveldb::DB> db(db_ptr);
   ASSERT_TRUE(status.ok());
 
-  // Setup the database with the scheme version 1.
+  // Setup the database with the schema version 1.
   leveldb::WriteBatch batch;
   batch.Put(kDatabaseVersionKey, "1");
   batch.Put(kChangeStampKey, "1");
@@ -102,11 +237,11 @@ TEST(DriveMetadataDBMigrationUtilTest, MigrationFromV1) {
                              kMetadataKeySeparator + url.path().AsUTF8Unsafe();
   batch.Put(metadata_key, metadata_string);
 
-  // Setup incremental sync origin and disabled origin.
-  batch.Put(kDriveIncrementalSyncOriginKeyPrefix + kOrigin1.spec(),
-            kResourceId1);
-  batch.Put(kDriveDisabledOriginKeyPrefix + kOrigin2.spec(),
+  // Setup origins.
+  batch.Put(kDriveBatchSyncOriginKeyPrefix + kOrigin1.spec(), kResourceId1);
+  batch.Put(kDriveIncrementalSyncOriginKeyPrefix + kOrigin2.spec(),
             kResourceId2);
+  batch.Put(kDriveDisabledOriginKeyPrefix + kOrigin3.spec(), kResourceId3);
 
   status = db->Write(leveldb::WriteOptions(), &batch);
   EXPECT_EQ(SYNC_STATUS_OK, LevelDBStatusToSyncStatusCode(status));
@@ -117,13 +252,20 @@ TEST(DriveMetadataDBMigrationUtilTest, MigrationFromV1) {
 
   scoped_ptr<leveldb::Iterator> itr(db->NewIterator(leveldb::ReadOptions()));
 
-  // Verify DB scheme version.
+  // Verify DB schema version.
   int64 database_version = 0;
   itr->Seek(kDatabaseVersionKey);
   EXPECT_TRUE(itr->Valid());
   EXPECT_TRUE(base::StringToInt64(itr->value().ToString(), &database_version));
   EXPECT_EQ(2, database_version);
 
+  // Verify the largest changestamp.
+  int64 changestamp = 0;
+  itr->Seek(kChangeStampKey);
+  EXPECT_TRUE(itr->Valid());
+  EXPECT_TRUE(base::StringToInt64(itr->value().ToString(), &changestamp));
+  EXPECT_EQ(1, changestamp);
+
   // Verify the sync root directory.
   itr->Seek(kSyncRootDirectoryKey);
   EXPECT_TRUE(itr->Valid());
@@ -139,15 +281,20 @@ TEST(DriveMetadataDBMigrationUtilTest, MigrationFromV1) {
   EXPECT_FALSE(metadata.conflicted());
   EXPECT_FALSE(metadata.to_be_fetched());
 
+  // Verify the batch sync origin.
+  itr->Seek(kDriveBatchSyncOriginKeyPrefix);
+  EXPECT_FALSE(StartsWithASCII(kDriveBatchSyncOriginKeyPrefix,
+                               itr->key().ToString(), true));
+
   // Verify the incremental sync origin.
   itr->Seek(kDriveIncrementalSyncOriginKeyPrefix);
   EXPECT_TRUE(itr->Valid());
-  EXPECT_EQ(RemoveWapiIdPrefix(kResourceId1), itr->value().ToString());
+  EXPECT_EQ(RemoveWapiIdPrefix(kResourceId2), itr->value().ToString());
 
   // Verify the disabled origin.
   itr->Seek(kDriveDisabledOriginKeyPrefix);
   EXPECT_TRUE(itr->Valid());
-  EXPECT_EQ(RemoveWapiIdPrefix(kResourceId2), itr->value().ToString());
+  EXPECT_EQ(RemoveWapiIdPrefix(kResourceId3), itr->value().ToString());
 }
 
 }  // namespace drive