Source/core/html/HTMLFormControlsCollection.h - Issue 159503003: Do not cause unnecessary node lists invalidation on id/name attribute change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormControlsCollection.h

Issue 159503003: Do not cause unnecessary node lists invalidation on id/name attribute change (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLFormControlsCollection.h

diff --git a/Source/core/html/HTMLFormControlsCollection.h b/Source/core/html/HTMLFormControlsCollection.h

index 84d6e97b2de8012a88300d94ceb07956ace2c005..d5d7029377f9a8a3d7c5a90e3b1b79efb202218c 100644

--- a/Source/core/html/HTMLFormControlsCollection.h

+++ b/Source/core/html/HTMLFormControlsCollection.h

@@ -49,13 +49,13 @@ public:

private:

explicit HTMLFormControlsCollection(ContainerNode*);

- virtual void updateNameCache() const OVERRIDE;

+ virtual void updateIdNameCache() const OVERRIDE;

virtual void supportedPropertyNames(Vector<String>& names) OVERRIDE;

const Vector<FormAssociatedElement*>& formControlElements() const;

const Vector<HTMLImageElement*>& formImageElements() const;

virtual Element* virtualItemAfter(Element*) const OVERRIDE;

- virtual void invalidateCache() const OVERRIDE;

+ virtual void invalidateCache(Document* oldDocument = 0) const OVERRIDE;

mutable Element* m_cachedElement;

mutable unsigned m_cachedElementOffsetInArray;

« no previous file with comments | « Source/core/html/HTMLCollection.cpp ('k') | Source/core/html/HTMLFormControlsCollection.cpp » ('j') | no next file with comments »