Do not cause unnecessary node lists invalidation on id/name attribute change

Source/core/dom/Document.cpp

Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index f14328912ea71952de8b4c144e6c1b1a8772239a..d62a80e8135b3a9814f1bb5ab990dd93615315ef 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -3560,8 +3560,6 @@ void Document::setCSSTarget(Element* n)
 
 void Document::registerNodeList(LiveNodeListBase* list)
 {
-    if (list->hasIdNameCache())

[Inactive, 2014/02/12 18:26:08]

We only want to cause invalidation if the NodeList has a *valid* id/name cache
so checking that the list can have an id/name cache when registering it is not
good enough.

We prefer to let the node list increment / decrement the document's
m_nodeListCounts[InvalidateOnIdNameAttrChange] when the id/name cache becomes
valid / invalidated.

This avoid iterating over all the node lists when an id or name attribute
changes and none of the HTMLCollections have a *valid* id/name cache.

-        m_nodeListCounts[InvalidateOnIdNameAttrChange]++;
     m_nodeListCounts[list->invalidationType()]++;
     if (list->isRootedAtDocument())
         m_listsInvalidatedAtDocument.add(list);
@@ -3569,8 +3567,6 @@ void Document::registerNodeList(LiveNodeListBase* list)
 
 void Document::unregisterNodeList(LiveNodeListBase* list)
 {
-    if (list->hasIdNameCache())
-        m_nodeListCounts[InvalidateOnIdNameAttrChange]--;
     m_nodeListCounts[list->invalidationType()]--;
     if (list->isRootedAtDocument()) {
         ASSERT(m_listsInvalidatedAtDocument.contains(list));