Source/core/html/HTMLAllCollection.cpp - Issue 159503003: Do not cause unnecessary node lists invalidation on id/name attribute change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLAllCollection.cpp

Issue 159503003: Do not cause unnecessary node lists invalidation on id/name attribute change (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Code clean up Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLAllCollection.cpp

diff --git a/Source/core/html/HTMLAllCollection.cpp b/Source/core/html/HTMLAllCollection.cpp

index dfbc4661c25779369797a710732d05c58175c6a4..4010931de505246975aee28d92b1181e5847b9c8 100644

--- a/Source/core/html/HTMLAllCollection.cpp

+++ b/Source/core/html/HTMLAllCollection.cpp

@@ -48,7 +48,7 @@ HTMLAllCollection::~HTMLAllCollection()

Element* HTMLAllCollection::namedItemWithIndex(const AtomicString& name, unsigned index) const

{

- updateNameCache();

+ updateIdNameCache();

if (Vector<Element*>* cache = idCache(name)) {

if (index < cache->size())

« Source/core/dom/NodeRareData.h ('K') | « Source/core/dom/NodeRareData.h ('k') | Source/core/html/HTMLCollection.h » ('j') | no next file with comments »