Source/core/dom/Document.cpp - Issue 159503003: Do not cause unnecessary node lists invalidation on id/name attribute change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.cpp

Issue 159503003: Do not cause unnecessary node lists invalidation on id/name attribute change (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Code clean up Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Document.cpp

diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp

index 90e8afb08463db1fc27d15d38f0514117fc655b1..26f3b754eb04bf55d3f07687ed336c1eba7374fc 100644

--- a/Source/core/dom/Document.cpp

+++ b/Source/core/dom/Document.cpp

@@ -3556,8 +3556,6 @@ void Document::setCSSTarget(Element* n)

void Document::registerNodeList(LiveNodeListBase* list)

{

- if (list->hasIdNameCache())

- m_nodeListCounts[InvalidateOnIdNameAttrChange]++;

m_nodeListCounts[list->invalidationType()]++;

if (list->isRootedAtDocument())

m_listsInvalidatedAtDocument.add(list);

@@ -3565,8 +3563,6 @@ void Document::registerNodeList(LiveNodeListBase* list)

void Document::unregisterNodeList(LiveNodeListBase* list)

{

- if (list->hasIdNameCache())

- m_nodeListCounts[InvalidateOnIdNameAttrChange]--;

m_nodeListCounts[list->invalidationType()]--;

if (list->isRootedAtDocument()) {

ASSERT(m_listsInvalidatedAtDocument.contains(list));

« Source/core/dom/Document.h ('K') | « Source/core/dom/Document.h ('k') | Source/core/dom/LiveNodeList.h » ('j') | Source/core/dom/NodeRareData.h » ('J')