Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 159503003: Do not cause unnecessary node lists invalidation on id/name attribute change (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/Document.h ('k') | Source/core/dom/LiveNodeList.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 3541 matching lines...) Expand 10 before | Expand all | Expand 10 after
3552 { 3552 {
3553 if (m_cssTarget) 3553 if (m_cssTarget)
3554 m_cssTarget->didAffectSelector(AffectedSelectorTarget); 3554 m_cssTarget->didAffectSelector(AffectedSelectorTarget);
3555 m_cssTarget = n; 3555 m_cssTarget = n;
3556 if (n) 3556 if (n)
3557 n->didAffectSelector(AffectedSelectorTarget); 3557 n->didAffectSelector(AffectedSelectorTarget);
3558 } 3558 }
3559 3559
3560 void Document::registerNodeList(LiveNodeListBase* list) 3560 void Document::registerNodeList(LiveNodeListBase* list)
3561 { 3561 {
3562 if (list->hasIdNameCache())
3563 m_nodeListCounts[InvalidateOnIdNameAttrChange]++;
3564 m_nodeListCounts[list->invalidationType()]++; 3562 m_nodeListCounts[list->invalidationType()]++;
3565 if (list->isRootedAtDocument()) 3563 if (list->isRootedAtDocument())
3566 m_listsInvalidatedAtDocument.add(list); 3564 m_listsInvalidatedAtDocument.add(list);
3567 } 3565 }
3568 3566
3569 void Document::unregisterNodeList(LiveNodeListBase* list) 3567 void Document::unregisterNodeList(LiveNodeListBase* list)
3570 { 3568 {
3571 if (list->hasIdNameCache())
3572 m_nodeListCounts[InvalidateOnIdNameAttrChange]--;
3573 m_nodeListCounts[list->invalidationType()]--; 3569 m_nodeListCounts[list->invalidationType()]--;
3574 if (list->isRootedAtDocument()) { 3570 if (list->isRootedAtDocument()) {
3575 ASSERT(m_listsInvalidatedAtDocument.contains(list)); 3571 ASSERT(m_listsInvalidatedAtDocument.contains(list));
3576 m_listsInvalidatedAtDocument.remove(list); 3572 m_listsInvalidatedAtDocument.remove(list);
3577 } 3573 }
3578 } 3574 }
3579 3575
3580 void Document::attachNodeIterator(NodeIterator* ni) 3576 void Document::attachNodeIterator(NodeIterator* ni)
3581 { 3577 {
3582 m_nodeIterators.add(ni); 3578 m_nodeIterators.add(ni);
(...skipping 1871 matching lines...) Expand 10 before | Expand all | Expand 10 after
5454 void Document::defaultEventHandler(Event* event) 5450 void Document::defaultEventHandler(Event* event)
5455 { 5451 {
5456 if (frame() && frame()->remotePlatformLayer()) { 5452 if (frame() && frame()->remotePlatformLayer()) {
5457 frame()->chromeClient().forwardInputEvent(this, event); 5453 frame()->chromeClient().forwardInputEvent(this, event);
5458 return; 5454 return;
5459 } 5455 }
5460 Node::defaultEventHandler(event); 5456 Node::defaultEventHandler(event);
5461 } 5457 }
5462 5458
5463 } // namespace WebCore 5459 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/dom/Document.h ('k') | Source/core/dom/LiveNodeList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698