Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: Source/core/dom/LiveNodeList.cpp

Issue 159503003: Do not cause unnecessary node lists invalidation on id/name attribute change (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2006, 2007, 2008, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 17 matching lines...) Expand all
28 28
29 namespace WebCore { 29 namespace WebCore {
30 30
31 ContainerNode& LiveNodeListBase::rootNode() const 31 ContainerNode& LiveNodeListBase::rootNode() const
32 { 32 {
33 if (isRootedAtDocument() && m_ownerNode->inDocument()) 33 if (isRootedAtDocument() && m_ownerNode->inDocument())
34 return m_ownerNode->document(); 34 return m_ownerNode->document();
35 return *m_ownerNode; 35 return *m_ownerNode;
36 } 36 }
37 37
38 void LiveNodeListBase::didMoveToDocument(Document& oldDocument, Document& newDoc ument)
39 {
40 invalidateCache(&oldDocument);
Inactive 2014/02/12 18:26:08 We need to pass the oldDocument to invalidateCache
41 oldDocument.unregisterNodeList(this);
42 newDocument.registerNodeList(this);
43 }
44
38 void LiveNodeListBase::invalidateIdNameCacheMaps() const 45 void LiveNodeListBase::invalidateIdNameCacheMaps() const
39 { 46 {
40 ASSERT(hasIdNameCache()); 47 ASSERT(hasIdNameCache());
41 static_cast<const HTMLCollection*>(this)->invalidateIdNameCacheMaps(); 48 static_cast<const HTMLCollection*>(this)->invalidateIdNameCacheMaps();
42 } 49 }
43 50
44 void LiveNodeList::invalidateCache() const 51 void LiveNodeList::invalidateCache(Document*) const
45 { 52 {
46 m_collectionIndexCache.invalidate(); 53 m_collectionIndexCache.invalidate();
47 } 54 }
48 55
49 } // namespace WebCore 56 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698