Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 159503003: Do not cause unnecessary node lists invalidation on id/name attribute change (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Code clean up Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 3538 matching lines...) Expand 10 before | Expand all | Expand 10 after
3549 { 3549 {
3550 if (m_cssTarget) 3550 if (m_cssTarget)
3551 m_cssTarget->didAffectSelector(AffectedSelectorTarget); 3551 m_cssTarget->didAffectSelector(AffectedSelectorTarget);
3552 m_cssTarget = n; 3552 m_cssTarget = n;
3553 if (n) 3553 if (n)
3554 n->didAffectSelector(AffectedSelectorTarget); 3554 n->didAffectSelector(AffectedSelectorTarget);
3555 } 3555 }
3556 3556
3557 void Document::registerNodeList(LiveNodeListBase* list) 3557 void Document::registerNodeList(LiveNodeListBase* list)
3558 { 3558 {
3559 if (list->hasIdNameCache())
3560 m_nodeListCounts[InvalidateOnIdNameAttrChange]++;
3561 m_nodeListCounts[list->invalidationType()]++; 3559 m_nodeListCounts[list->invalidationType()]++;
3562 if (list->isRootedAtDocument()) 3560 if (list->isRootedAtDocument())
3563 m_listsInvalidatedAtDocument.add(list); 3561 m_listsInvalidatedAtDocument.add(list);
3564 } 3562 }
3565 3563
3566 void Document::unregisterNodeList(LiveNodeListBase* list) 3564 void Document::unregisterNodeList(LiveNodeListBase* list)
3567 { 3565 {
3568 if (list->hasIdNameCache())
3569 m_nodeListCounts[InvalidateOnIdNameAttrChange]--;
3570 m_nodeListCounts[list->invalidationType()]--; 3566 m_nodeListCounts[list->invalidationType()]--;
3571 if (list->isRootedAtDocument()) { 3567 if (list->isRootedAtDocument()) {
3572 ASSERT(m_listsInvalidatedAtDocument.contains(list)); 3568 ASSERT(m_listsInvalidatedAtDocument.contains(list));
3573 m_listsInvalidatedAtDocument.remove(list); 3569 m_listsInvalidatedAtDocument.remove(list);
3574 } 3570 }
3575 } 3571 }
3576 3572
3577 void Document::attachNodeIterator(NodeIterator* ni) 3573 void Document::attachNodeIterator(NodeIterator* ni)
3578 { 3574 {
3579 m_nodeIterators.add(ni); 3575 m_nodeIterators.add(ni);
(...skipping 1868 matching lines...) Expand 10 before | Expand all | Expand 10 after
5448 void Document::defaultEventHandler(Event* event) 5444 void Document::defaultEventHandler(Event* event)
5449 { 5445 {
5450 if (frame() && frame()->remotePlatformLayer()) { 5446 if (frame() && frame()->remotePlatformLayer()) {
5451 frame()->chromeClient().forwardInputEvent(this, event); 5447 frame()->chromeClient().forwardInputEvent(this, event);
5452 return; 5448 return;
5453 } 5449 }
5454 Node::defaultEventHandler(event); 5450 Node::defaultEventHandler(event);
5455 } 5451 }
5456 5452
5457 } // namespace WebCore 5453 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698