Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: frontend/client/src/autotest/afe/JobStatusDataSource.java

Issue 1595019: Merge remote branch 'origin/upstream' into tempbranch (Closed)
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « database/schema_051.sql ('k') | frontend/client/src/autotest/common/DomUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frontend/client/src/autotest/afe/JobStatusDataSource.java
diff --git a/frontend/client/src/autotest/afe/JobStatusDataSource.java b/frontend/client/src/autotest/afe/JobStatusDataSource.java
index 5632d4f914a63e50bc5693d9377f05a63a93dac0..91ca6df3d6b0f5b9ba7efa41f40cfd2965eaebc0 100644
--- a/frontend/client/src/autotest/afe/JobStatusDataSource.java
+++ b/frontend/client/src/autotest/afe/JobStatusDataSource.java
@@ -53,16 +53,21 @@ class JobStatusDataSource extends RpcDataSource {
String translation = translateStatus(status);
queueEntry.put("status", new JSONString(translation));
- JSONValue host = queueEntry.get("host");
- if (host.isNull() != null) {
+ boolean hasHost = (queueEntry.get("host").isNull() == null);
+ boolean hasMetaHost = (queueEntry.get("meta_host") == null);
+
+ if (!hasHost && !hasMetaHost) {
+ queueEntry.put("hostname", new JSONString("(hostless)"));
+ rows.add(queueEntry);
+
+ } else if (!hasHost && hasMetaHost) {
// metahost
incrementMetaHostCount(metaHostEntries, queueEntry);
- continue;
+ } else {
+ // non-metahost
+ processHostData(queueEntry);
+ rows.add(queueEntry);
}
-
- // non-metahost
- processHostData(queueEntry);
- rows.add(queueEntry);
}
addMetaHostRows(metaHostEntries, rows);
« no previous file with comments | « database/schema_051.sql ('k') | frontend/client/src/autotest/common/DomUtils.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698