| OLD | NEW |
| 1 diff -urw lmbench3.old/Makefile lmbench3/Makefile | 1 From 05546bfc9968a58e9569f2a8a9764f6e53f20167 Mon Sep 17 00:00:00 2001 |
| 2 --- lmbench3.old/Makefile» 2005-08-22 17:19:55.000000000 -0700 | 2 From: Lucas Meneghel Rodrigues <lmr@redhat.com> |
| 3 +++ lmbench3/Makefile» 2009-12-02 15:55:29.000000000 -0800 | 3 Date: Thu, 8 Apr 2010 10:38:13 -0300 |
| 4 Subject: [PATCH 1/2] Fix build issues with lmbench |
| 5 |
| 6 * removes Makefile references to bitkeeper |
| 7 * default mail to no, fix job placement defaults (masouds) |
| 8 * adds "config" Makefile targets to perform configuration only |
| 9 * changes scripts/getlist to consider result files that do |
| 10 * not start with "[lmbench 3.x..." (still requires such a line somewhere |
| 11 in the first 1000 bytes of the file) |
| 12 --- |
| 13 Makefile | 4 ++++ |
| 14 scripts/config-run | 13 ++++++++----- |
| 15 scripts/getlist | 4 ++-- |
| 16 src/Makefile | 44 ++++++-------------------------------------- |
| 17 4 files changed, 20 insertions(+), 45 deletions(-) |
| 18 |
| 19 diff --git a/Makefile b/Makefile |
| 20 index d3d00f4..9a568f3 100644 |
| 21 --- a/Makefile |
| 22 +++ b/Makefile |
| 4 @@ -5,6 +5,7 @@ | 23 @@ -5,6 +5,7 @@ |
| 5 # | 24 # |
| 6 # build (default) go to the source directory and build the bench
mark | 25 # build (default) go to the source directory and build the bench
mark |
| 7 # results go to the source directory and build and run the benchmark | 26 # results go to the source directory and build and run the benchmark |
| 8 +# config configures run parameters | 27 +# config configures run parameters |
| 9 # rerun run the benchmark again | 28 # rerun run the benchmark again |
| 10 # see see the results that came with this release | 29 # see see the results that came with this release |
| 11 # Go to the results directory and read the Makefile. | 30 # Go to the results directory and read the Makefile. |
| 12 @@ -22,6 +23,9 @@ | 31 @@ -22,6 +23,9 @@ build: |
| 13 results: FRC | 32 results: FRC |
| 14 cd src && $(MAKE) results | 33 cd src && $(MAKE) results |
| 15 | 34 |
| 16 +config: | 35 +config: |
| 17 + cd src && $(MAKE) config | 36 + cd src && $(MAKE) config |
| 18 + | 37 + |
| 19 rerun: | 38 rerun: |
| 20 cd src && $(MAKE) rerun | 39 cd src && $(MAKE) rerun |
| 21 | 40 |
| 22 diff -urw lmbench3.old/scripts/config-run lmbench3/scripts/config-run | 41 diff --git a/scripts/config-run b/scripts/config-run |
| 23 --- lmbench3.old/scripts/config-run» 2005-08-22 17:19:55.000000000 -0700 | 42 index b8c17d5..9958a31 100755 |
| 24 +++ lmbench3/scripts/config-run»2009-12-03 15:03:46.000000000 -0800 | 43 --- a/scripts/config-run |
| 25 @@ -115,9 +115,12 @@ | 44 +++ b/scripts/config-run |
| 45 @@ -115,9 +115,12 @@ three attendent child processes sending data down the pipes
and |
| 26 three benchmark processes reading data and doing the measurements. | 46 three benchmark processes reading data and doing the measurements. |
| 27 | 47 |
| 28 EOF | 48 EOF |
| 29 - echo $ECHON "Job placement selection: $ECHOC" | 49 - echo $ECHON "Job placement selection: $ECHOC" |
| 30 + echo $ECHON "Job placement selection [DEFAULT: 1]: $ECHOC" | 50 + echo $ECHON "Job placement selection [DEFAULT: 1]: $ECHOC" |
| 31 read LMBENCH_SCHED | 51 read LMBENCH_SCHED |
| 32 AGAIN=N | 52 AGAIN=N |
| 33 + if [ "$LMBENCH_SCHED" == "" ]; then | 53 + if [ "$LMBENCH_SCHED" == "" ]; then |
| 34 + LMBENCH_SCHED=1 | 54 + LMBENCH_SCHED=1 |
| 35 + fi | 55 + fi |
| 36 case "$LMBENCH_SCHED" in | 56 case "$LMBENCH_SCHED" in |
| 37 1) LMBENCH_SCHED=DEFAULT;; | 57 1) LMBENCH_SCHED=DEFAULT;; |
| 38 2) LMBENCH_SCHED=BALANCED;; | 58 2) LMBENCH_SCHED=BALANCED;; |
| 39 @@ -657,13 +660,13 @@ | 59 @@ -657,13 +660,13 @@ fast box, they may be made available on the lmbench web pa
ge, which is |
| 40 | 60 |
| 41 EOF | 61 EOF |
| 42 | 62 |
| 43 -echo $ECHON "Mail results [default yes] $ECHOC" | 63 -echo $ECHON "Mail results [default yes] $ECHOC" |
| 44 +echo $ECHON "Mail results [default no] $ECHOC" | 64 +echo $ECHON "Mail results [default no] $ECHOC" |
| 45 read MAIL | 65 read MAIL |
| 46 case $MAIL in | 66 case $MAIL in |
| 47 - [Nn]*) MAIL=no | 67 - [Nn]*) MAIL=no |
| 48 - echo OK, no results mailed. | 68 - echo OK, no results mailed. |
| 49 + [Yy]*) MAIL=yes | 69 + [Yy]*) MAIL=yes |
| 50 + echo OK, results will be mailed. | 70 + echo OK, results will be mailed. |
| 51 ;; | 71 ;; |
| 52 - *) MAIL=yes | 72 - *) MAIL=yes |
| 53 + *) MAIL=no | 73 + *) MAIL=no |
| 54 ;; | 74 ;; |
| 55 esac | 75 esac |
| 56 | 76 |
| 57 diff -urw lmbench3.old/scripts/getlist lmbench3/scripts/getlist | 77 diff --git a/scripts/getlist b/scripts/getlist |
| 58 --- lmbench3.old/scripts/getlist» 2005-08-22 17:19:55.000000000 -0700 | 78 index 8c35970..f03b679 100755 |
| 59 +++ lmbench3/scripts/getlist» 2009-12-01 17:52:29.000000000 -0800 | 79 --- a/scripts/getlist |
| 60 @@ -22,9 +22,9 @@ | 80 +++ b/scripts/getlist |
| 81 @@ -22,9 +22,9 @@ if (-f $LIST) { |
| 61 foreach $file (@files) { | 82 foreach $file (@files) { |
| 62 next if $file =~ /\.INFO$/; | 83 next if $file =~ /\.INFO$/; |
| 63 open(FD, $file) || next; | 84 open(FD, $file) || next; |
| 64 - next unless defined($_ = <FD>); | 85 - next unless defined($_ = <FD>); |
| 65 + next unless read(FD, $_, 1000); | 86 + next unless read(FD, $_, 1000); |
| 66 close(FD); | 87 close(FD); |
| 67 - next unless /^\[lmbench3.[01]/; | 88 - next unless /^\[lmbench3.[01]/; |
| 68 + next unless /^\[lmbench3.[01]/m; | 89 + next unless /^\[lmbench3.[01]/m; |
| 69 print "$file "; | 90 print "$file "; |
| 70 } | 91 } |
| 71 print "\n"; | 92 print "\n"; |
| 72 diff -urw lmbench3.old/src/Makefile lmbench3/src/Makefile | 93 diff --git a/src/Makefile b/src/Makefile |
| 73 --- lmbench3.old/src/Makefile» 2005-08-22 17:19:54.000000000 -0700 | 94 index 2555014..cf0b779 100644 |
| 74 +++ lmbench3/src/Makefile» 2009-12-02 15:55:22.000000000 -0800 | 95 --- a/src/Makefile |
| 96 +++ b/src/Makefile |
| 75 @@ -4,6 +4,7 @@ | 97 @@ -4,6 +4,7 @@ |
| 76 # | 98 # |
| 77 # lmbench [default] builds the benchmark suite for the current os/arch | 99 # lmbench [default] builds the benchmark suite for the current os/arch |
| 78 # results builds, configures run parameters, and runs the benchmark | 100 # results builds, configures run parameters, and runs the benchmark |
| 79 +# config configures run parameters | 101 +# config configures run parameters |
| 80 # rerun reruns the benchmark using the same parameters as last t
ime | 102 # rerun reruns the benchmark using the same parameters as last t
ime |
| 81 # scaling reruns the benchmark using same parameters as last time, | 103 # scaling reruns the benchmark using same parameters as last time, |
| 82 # except it asks what scaling value to use | 104 # except it asks what scaling value to use |
| 83 @@ -118,8 +119,10 @@ | 105 @@ -118,8 +119,10 @@ results: lmbench |
| 84 @env OS="${OS}" ../scripts/config-run | 106 @env OS="${OS}" ../scripts/config-run |
| 85 @env OS="${OS}" ../scripts/results | 107 @env OS="${OS}" ../scripts/results |
| 86 | 108 |
| 87 -rerun: lmbench | 109 -rerun: lmbench |
| 88 +config: lmbench | 110 +config: lmbench |
| 89 @if [ ! -f $(CONFIG) ]; then env OS="${OS}" ../scripts/config-run; fi | 111 @if [ ! -f $(CONFIG) ]; then env OS="${OS}" ../scripts/config-run; fi |
| 90 + | 112 + |
| 91 +rerun: lmbench config | 113 +rerun: lmbench config |
| 92 @env OS="${OS}" ../scripts/results | 114 @env OS="${OS}" ../scripts/results |
| 93 | 115 |
| 94 scaling: lmbench | 116 scaling: lmbench |
| 95 @@ -165,41 +168,6 @@ | 117 @@ -165,41 +168,6 @@ debug: |
| 96 assembler: | 118 assembler: |
| 97 @env CFLAGS=-O MAKE="$(MAKE)" MAKEFLAGS="$(MAKEFLAGS)" CC="${CC}" OS="${
OS}" ../scripts/build asm | 119 @env CFLAGS=-O MAKE="$(MAKE)" MAKEFLAGS="$(MAKEFLAGS)" CC="${CC}" OS="${
OS}" ../scripts/build asm |
| 98 | 120 |
| 99 -bk.ver: ../SCCS/s.ChangeSet | 121 -bk.ver: ../SCCS/s.ChangeSet |
| 100 - rm -f bk.ver | 122 - rm -f bk.ver |
| 101 - -echo `bk prs -hr+ -d'$$if(:SYMBOL:){:SYMBOL: }:UTC:' ../ChangeSet;` > b
k.ver | 123 - -echo `bk prs -hr+ -d'$$if(:SYMBOL:){:SYMBOL: }:UTC:' ../ChangeSet;` > b
k.ver |
| 102 - touch bk.ver | 124 - touch bk.ver |
| 103 - | 125 - |
| 104 -dist: bk.ver | 126 -dist: bk.ver |
| 105 - @if [ "X`cd ..; bk sfiles -c`" != "X" ]; then \ | 127 - @if [ "X`cd ..; bk sfiles -c`" != "X" ]; then \ |
| (...skipping 21 matching lines...) Expand all Loading... |
| 127 - cd src; \ | 149 - cd src; \ |
| 128 - make bk.ver; \ | 150 - make bk.ver; \ |
| 129 - cd /tmp; \ | 151 - cd /tmp; \ |
| 130 - tar czf $${SRCDIR}/../lmbench-$${VERSION}.tgz \ | 152 - tar czf $${SRCDIR}/../lmbench-$${VERSION}.tgz \ |
| 131 - lmbench-$${VERSION}; \ | 153 - lmbench-$${VERSION}; \ |
| 132 - rm -rf /tmp/lmbench-$${VERSION}; | 154 - rm -rf /tmp/lmbench-$${VERSION}; |
| 133 - | 155 - |
| 134 get $(SRCS): | 156 get $(SRCS): |
| 135 -get -s $(SRCS) | 157 -get -s $(SRCS) |
| 136 | 158 |
| 137 @@ -228,9 +196,9 @@ | 159 @@ -228,9 +196,9 @@ testmake: $(SRCS) $(UTILS) # used by scripts/make to test gm
ake |
| 138 install install-target dist get edit get-e clean clobber \ | 160 install install-target dist get edit get-e clean clobber \ |
| 139 share depend testmake | 161 share depend testmake |
| 140 | 162 |
| 141 -$O/lmbench : ../scripts/lmbench bk.ver | 163 -$O/lmbench : ../scripts/lmbench bk.ver |
| 142 +$O/lmbench : ../scripts/lmbench | 164 +$O/lmbench : ../scripts/lmbench |
| 143 rm -f $O/lmbench | 165 rm -f $O/lmbench |
| 144 - sed -e "s/<version>/`cat bk.ver`/g" < ../scripts/lmbench > $O/lmbench | 166 - sed -e "s/<version>/`cat bk.ver`/g" < ../scripts/lmbench > $O/lmbench |
| 145 + sed -e "s/<version>/666/g" < ../scripts/lmbench > $O/lmbench | 167 + sed -e "s/<version>/666/g" < ../scripts/lmbench > $O/lmbench |
| 146 chmod +x $O/lmbench | 168 chmod +x $O/lmbench |
| 147 | 169 |
| 148 $O/lmbench.a: $(LIBOBJS) | 170 $O/lmbench.a: $(LIBOBJS) |
| 171 -- |
| 172 1.6.6.1 |
| 173 |
| OLD | NEW |