Issue 15950004: [Quota] Wire up limited origin usage retrieving.

Issue 15950004: [Quota] Wire up limited origin usage retrieving. (Closed)

Created:
7 years, 6 months ago by tzik

Modified:
7 years, 6 months ago

Reviewers:
kinuko

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Quota] Wire up limited origin usage retrieving. This CL implements UsageTracker::GetGlobalLimitedUsage without gathering usages for all origins. Using cache-disabled temporary unlimited storage will no longer hurt performance for other origins, after the change. The CL also fixes usage calculation: the usages of cache-disabled limited origins will be counted as limited storage, though it was counted as unlimited, previously. BUG=220029 TEST=UsageTrackerTest.LimitedGlobalUsageTest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203125

Patch Set 1 #

Patch Set 2 : +test #

Patch Set 3 : stop spicial handilng for temporary fs #

Patch Set 4 : drop unneeded DCHECK #

Patch Set 5 : fix test expectation #

Total comments: 1

Patch Set 6 : rebase #

Patch Set 7 : test expectation fix #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+167 lines, -44 lines)			Patch
M	webkit/browser/fileapi/obfuscated_file_util.cc	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/browser/fileapi/sandbox_mount_point_provider.cc	View	1 2 3 4 5	1 chunk	+0 lines, -6 lines	0 comments	Download
M	webkit/browser/quota/quota_callbacks.h	View	1 2 3 4 5 6	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/browser/quota/usage_tracker.h	View	1 2 3 4 5	5 chunks	+15 lines, -7 lines	0 comments	Download
M	webkit/browser/quota/usage_tracker.cc	View	1 2 3 4 5	8 chunks	+102 lines, -29 lines	0 comments	Download
M	webkit/browser/quota/usage_tracker_unittest.cc	View	1 2 3 4 5 6	3 chunks	+48 lines, -1 line	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

tzik

On 2013/05/29 11:44:08, kinuko wrote: > Hmm... this's making PPAPI tests fail? Let me see...

7 years, 6 months ago (2013-05-29 12:21:44 UTC) #3

tzik

On 2013/05/29 12:21:44, tzik wrote: > On 2013/05/29 11:44:08, kinuko wrote: > > Hmm... this's ...

7 years, 6 months ago (2013-05-30 03:53:44 UTC) #4

kinuko

lgtm https://codereview.chromium.org/15950004/diff/19001/webkit/quota/usage_tracker.cc File webkit/quota/usage_tracker.cc (right): https://codereview.chromium.org/15950004/diff/19001/webkit/quota/usage_tracker.cc#newcode126 webkit/quota/usage_tracker.cc:126: accumulator.Run(0); Hmm, can we possibly cleanup this pattern ...

7 years, 6 months ago (2013-05-30 05:56:32 UTC) #6

kinuko

http://build.chromium.org/p/tryserver.chromium/builders/mac_rel/builds/133008/steps/content_unittests/logs/LimitedGlobalUsageTest broken?

7 years, 6 months ago (2013-05-30 05:57:08 UTC) #7

tzik

On 2013/05/30 05:57:08, kinuko wrote: > http://build.chromium.org/p/tryserver.chromium/builders/mac_rel/builds/133008/steps/content_unittests/logs/LimitedGlobalUsageTest > > broken? Thanks! I've set wrong expectation ...

7 years, 6 months ago (2013-05-30 06:20:53 UTC) #8

kinuko

On 2013/05/30 06:20:53, tzik wrote: > On 2013/05/30 05:57:08, kinuko wrote: > > > http://build.chromium.org/p/tryserver.chromium/builders/mac_rel/builds/133008/steps/content_unittests/logs/LimitedGlobalUsageTest ...

7 years, 6 months ago (2013-05-30 06:23:15 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/15950004/32001

7 years, 6 months ago (2013-05-30 06:47:23 UTC) #10

Message was sent while issue was closed.

Change committed as 203125

Expand Messages | Collapse Messages