Made the open menu item in the context menu updated when the context menu is open.

chrome/browser/resources/file_manager/js/file_selection.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * The current selection object.
  *
  * @param {FileManager} fileManager FileManager instance.
@@ skipping 458 matching lines @@
 
 /**
  * Calculates async selection stats and updates secondary UI elements.
  *
  * @param {FileSelection} selection The selection object.
  */
 FileSelectionHandler.prototype.updateFileSelectionAsync = function(selection) {
   if (this.selection != selection) return;
 
   // Update the file tasks.
-  var onTasks = function() {
-    if (this.selection != selection) return;
-    selection.tasks.display(this.taskItems_);
-    selection.tasks.updateMenuItem();
-  }.bind(this);
-
   if (this.fileManager_.dialogType == DialogType.FULL_PAGE &&
       selection.directoryCount == 0 && selection.fileCount > 0) {
-    selection.createTasks(onTasks);
+    selection.createTasks(function() {

[yoshiki, 2013/05/28 02:26:48]

Why moved to here? The logic doesn't seem changed.

[hirono, 2013/05/28 04:08:44]

If a callback function is assigned to a variable, the callback function can be
used from everywhere in the outer function.  updateFileSelectionAsync is a bit
large, so, I'd like to show that the callback function is only used here.

[yoshiki, 2013/05/28 04:20:33]

Got it. Thanks for explanation.

+        if (this.selection != selection) return;

[yoshiki, 2013/05/28 02:26:48]

nit: New line after condition.

[hirono, 2013/05/28 04:08:44]

Done.

+        selection.tasks.display(this.taskItems_);
+        selection.tasks.updateMenuItem();
+    }.bind(this));
   } else {
     this.taskItems_.hidden = true;
   }
 
-  // Update the UI.
+  // Update preview panels.
   var wasVisible = this.isPreviewPanelVisibile_();
+  var thumbnailEntries = null;
+  if (util.platform.newUI() && selection.totalCount == 0) {
+    thumbnailEntries = [
+      this.fileManager_.getCurrentDirectoryEntry()
+    ];
+  } else {
+    thumbnailEntries = selection.entries;
+    selection.computeBytes(function() {

[yoshiki, 2013/05/28 02:26:48]

if selection.totalCount == 1, we don't need to compute size of the files. 

[hirono, 2013/05/28 04:08:44]

Done.

+      if (this.selection != selection) return;

[yoshiki, 2013/05/28 02:26:48]

nit: New line after condition.

[hirono, 2013/05/28 04:08:44]

Done.

+      this.updatePreviewPanelText_();
+    }.bind(this));
+  }
   this.updatePreviewPanelVisibility_();
+  this.updatePreviewPanelText_();
+  this.showPreviewThumbnails_(thumbnailEntries);
 
-  if (util.platform.newUI() && selection.totalCount == 0) {
+  // Update breadcrums.
+  var updateTarget = null;
+  if (util.platform.newUI()) {
     var path = this.fileManager_.getCurrentDirectory();
-    // Hides the breadcrumbs list on the root path.
-    if (PathUtil.isRootPath(path))
-      this.updatePreviewPanelBreadcrumbs_(null);
-    else
-      this.updatePreviewPanelBreadcrumbs_(path);
-    var entry = this.fileManager_.getCurrentDirectoryEntry();
-    this.showPreviewThumbnails_([entry]);
-    this.updatePreviewPanelText_();
-    return;
+    if (selection.totalCount == 1) {
+      // Shows the breadcrumb list.
+      updateTarget = selection.entries[0].fullPath;
+    } else if (selection.totalCount == 0 && !PathUtil.isRootPath(path)) {
+      // Hides the breadcrumbs list on the root path.

[yoshiki, 2013/05/28 02:26:48]

Does this comment appropriate for this block?

Maybe:
// Shows the breadcrumb list when no file is selected and the current directory
is non-root path.

[hirono, 2013/05/28 04:08:44]

Done.

+      updateTarget = path;
+    }
   }
+  this.updatePreviewPanelBreadcrumbs_(updateTarget);
 
-  this.fileManager_.updateContextMenuActionItems(null, false);
+  // Scroll to item
   if (!wasVisible && this.selection.totalCount == 1) {
     var list = this.fileManager_.getCurrentList();
     list.scrollIndexIntoView(list.selectionModel.selectedIndex);
   }
 
   // Sync the commands availability.
   var commands = this.fileManager_.dialogDom_.querySelectorAll('command');

[yoshiki, 2013/05/28 02:26:48]

We don't need to do it when no file is selected.

[hirono, 2013/05/28 04:08:44]

Done.

   for (var i = 0; i < commands.length; i++)
     commands[i].canExecuteChange();
 
-  if (!util.platform.newUI()) {
-    this.updateSearchBreadcrumbs_();
-    // Update the summary information.
-    var onBytes = function() {
-      if (this.selection != selection) return;
-      this.updatePreviewPanelText_();
-    }.bind(this);
-    selection.computeBytes(onBytes);
-    this.updatePreviewPanelText_();
-  } else {
-    if (selection.totalCount == 1) {
-      // Shows the breadcrumb list.
-      var firstEntry = selection.entries[0];
-      this.updatePreviewPanelBreadcrumbs_(firstEntry.fullPath);
-      this.updatePreviewPanelText_();
-    } else {
-      this.updatePreviewPanelBreadcrumbs_(null);
-
-      // Update the summary information.
-      var onBytes = function() {
-        if (this.selection != selection) return;
-        this.updatePreviewPanelText_();
-      }.bind(this);
-      selection.computeBytes(onBytes);
-      this.updatePreviewPanelText_();
-    }
-  }
+  // Update context menu.
+  this.fileManager_.updateContextMenuActionItems(null, false);
 
   // Inform tests it's OK to click buttons now.
   chrome.test.sendMessage('selection-change-complete');
-
-  // Show thumbnails.
-  this.showPreviewThumbnails_(selection.entries);
 };
 
 /**
  * Renders preview thumbnails in preview panel.
  *
  * @param {Array.<FileEntry>} entries The entries of selected object.
  * @private
  */
 FileSelectionHandler.prototype.showPreviewThumbnails_ = function(entries) {
   var selection = this.selection;
@@ skipping 195 matching lines @@
   style.left = (boxWidth - imageWidth) / 2 + 'px';
   style.top = (boxHeight - imageHeight) / 2 + 'px';
   style.position = 'relative';
 
   util.applyTransform(largeImage, transform);
 
   largeImageBox.appendChild(largeImage);
   largeImageBox.style.zIndex = 1000;
   return true;
 };