Issue 159493002: Add test plumbing so that layout tests can query whether a compositor frame was requested

Issue 159493002: Add test plumbing so that layout tests can query whether a compositor frame was requested (Closed)

Created:
6 years, 10 months ago by shawnsingh

Modified:
6 years, 10 months ago

Reviewers:
jamesr, abarth-chromium

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add test plumbing so that layout tests can query whether a compositor frame was requested BUG=336676 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250549

Patch Set 3 : addressed m_paintRect feedback #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	content/shell/renderer/test_runner/WebTestProxy.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
	M	content/shell/renderer/test_runner/WebTestProxy.cpp	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

shawnsingh

jamesr@ FYI abarth@ PTAL as OWNER - this is plumbing for https://codereview.chromium.org/139103009/ - this patch ...

6 years, 10 months ago (2014-02-11 01:42:05 UTC) #1

jamesr

lgtm (although i don't have OWNERS here) https://codereview.chromium.org/159493002/diff/40001/content/shell/renderer/test_runner/WebTestProxy.cpp File content/shell/renderer/test_runner/WebTestProxy.cpp (right): https://codereview.chromium.org/159493002/diff/40001/content/shell/renderer/test_runner/WebTestProxy.cpp#newcode743 content/shell/renderer/test_runner/WebTestProxy.cpp:743: return m_animateScheduled; ...

6 years, 10 months ago (2014-02-11 01:47:42 UTC) #2

shawnsingh

https://codereview.chromium.org/159493002/diff/40001/content/shell/renderer/test_runner/WebTestProxy.cpp File content/shell/renderer/test_runner/WebTestProxy.cpp (right): https://codereview.chromium.org/159493002/diff/40001/content/shell/renderer/test_runner/WebTestProxy.cpp#newcode743 content/shell/renderer/test_runner/WebTestProxy.cpp:743: return m_animateScheduled; On 2014/02/11 01:47:42, jamesr wrote: > i ...

6 years, 10 months ago (2014-02-11 02:02:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shawnsingh@chromium.org/159493002/90001

6 years, 10 months ago (2014-02-11 19:32:04 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shawnsingh@chromium.org/159493002/90001

6 years, 10 months ago (2014-02-11 21:27:20 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shawnsingh@chromium.org/159493002/90001

6 years, 10 months ago (2014-02-11 22:05:05 UTC) #8

Message was sent while issue was closed.

Change committed as 250549

Expand Messages | Collapse Messages