Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4548)

Unified Diff: chrome/browser/translate/translate_manager_browsertest.cc

Issue 15949022: Translate: language list smart updater (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: disable network update on mac infobar tests Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_manager_browsertest.cc
diff --git a/chrome/browser/translate/translate_manager_browsertest.cc b/chrome/browser/translate/translate_manager_browsertest.cc
index 5de2bb8999e83199f1bc92733808c8fd0741efc0..832a66f6dff7c02f551e25e75592fc2644388bdf 100644
--- a/chrome/browser/translate/translate_manager_browsertest.cc
+++ b/chrome/browser/translate/translate_manager_browsertest.cc
@@ -632,17 +632,13 @@ TEST_F(TranslateManagerBrowserTest, FetchLanguagesFromTranslateServer) {
server_languages.push_back("fr-FR");
server_languages.push_back("xx");
- // First, get the default languages list:
+ // First, get the default languages list. Note that calling
+ // GetSupportedLanguages() invokes RequestLanguageList() internally.
std::vector<std::string> default_supported_languages;
TranslateManager::GetSupportedLanguages(&default_supported_languages);
// To make sure we got the defaults and don't confuse them with the mocks.
ASSERT_NE(default_supported_languages.size(), server_languages.size());
- Profile* profile =
- Profile::FromBrowserContext(web_contents()->GetBrowserContext());
- PrefService* prefs = profile->GetPrefs();
- TranslateManager::GetInstance()->FetchLanguageListFromTranslateServer(prefs);
-
// Check that we still get the defaults until the URLFetch has completed.
std::vector<std::string> current_supported_languages;
TranslateManager::GetSupportedLanguages(&current_supported_languages);
@@ -655,7 +651,6 @@ TEST_F(TranslateManagerBrowserTest, FetchLanguagesFromTranslateServer) {
EXPECT_EQ(default_supported_languages, current_supported_languages);
// Now check that we got the appropriate set of languages from the server.
- TranslateManager::GetInstance()->FetchLanguageListFromTranslateServer(prefs);
SimulateSupportedLanguagesURLFetch(true, server_languages);
current_supported_languages.clear();
TranslateManager::GetSupportedLanguages(&current_supported_languages);
« no previous file with comments | « chrome/browser/translate/translate_language_list.cc ('k') | chrome/browser/translate/translate_url_fetcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698