Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: chrome/browser/translate/translate_language_list.h

Issue 15949022: Translate: language list smart updater (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: disable network update on mac infobar tests Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_browser_main.cc ('k') | chrome/browser/translate/translate_language_list.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/translate_language_list.h
diff --git a/chrome/browser/translate/translate_language_list.h b/chrome/browser/translate/translate_language_list.h
index c5ded072e542cbf8ef9f1fe4fdc9d7b3b7407c7a..a3f3a65d1d8dc6001dfc62b68fd64119b6ae20bb 100644
--- a/chrome/browser/translate/translate_language_list.h
+++ b/chrome/browser/translate/translate_language_list.h
@@ -11,13 +11,14 @@
#include "base/memory/scoped_ptr.h"
#include "base/time.h"
+#include "chrome/browser/web_resource/resource_request_allowed_notifier.h"
class TranslateURLFetcher;
// The TranslateLanguageList class is responsible for maintaining the latest
// supporting language list.
// This class is defined to be owned only by TranslateManager.
-class TranslateLanguageList {
+class TranslateLanguageList : public ResourceRequestAllowedNotifier::Observer {
public:
TranslateLanguageList();
virtual ~TranslateLanguageList();
@@ -47,6 +48,12 @@ class TranslateLanguageList {
// reach to limits.
void RequestLanguageList();
+ // ResourceRequestAllowedNotifier::Observer implementation:
+ virtual void OnResourceRequestsAllowed() OVERRIDE;
+
+ // Disables the language list updater. This is used only for testing now.
+ static void DisableUpdate();
+
// static const values shared with our browser tests.
static const char kLanguageListCallbackName[];
static const char kTargetLanguagesKey[];
@@ -82,6 +89,9 @@ class TranslateLanguageList {
// The last-updated time when the language list is sent.
base::Time last_updated_;
+ // Helper class to know if it's allowed to make network resource requests.
+ ResourceRequestAllowedNotifier resource_request_allowed_notifier_;
+
DISALLOW_COPY_AND_ASSIGN(TranslateLanguageList);
};
« no previous file with comments | « chrome/browser/chrome_browser_main.cc ('k') | chrome/browser/translate/translate_language_list.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698