Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2513)

Unified Diff: chrome/browser/translate/translate_language_list.h

Issue 15949022: Translate: language list smart updater (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review #15 Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_language_list.h
diff --git a/chrome/browser/translate/translate_language_list.h b/chrome/browser/translate/translate_language_list.h
index c8d9c4ea03e3a818ea5072f6f75b076f69f61ad3..54faccffe3071c1eb718ef01f4cb0efc35bac82f 100644
--- a/chrome/browser/translate/translate_language_list.h
+++ b/chrome/browser/translate/translate_language_list.h
@@ -11,6 +11,7 @@
#include "base/callback.h"
#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/web_resource/resource_request_allowed_notifier.h"
#include "googleurl/src/gurl.h"
#include "net/url_request/url_fetcher_delegate.h"
@@ -21,7 +22,7 @@ class URLFetcher;
// The TranslateLanguageList class is responsible for maintaining the latest
// supporting language list.
// This class is defined to be owned only by TranslateManager.
-class TranslateLanguageList {
+class TranslateLanguageList : public ResourceRequestAllowedNotifier::Observer {
public:
TranslateLanguageList();
virtual ~TranslateLanguageList();
@@ -47,6 +48,9 @@ class TranslateLanguageList {
// already updated.
void RequestLanguageList();
+ // ResourceRequestAllowedNotifier::Observer implementation:
+ virtual void OnResourceRequestsAllowed() OVERRIDE;
+
// static const values shared with our browser tests.
static const char kLanguageListCallbackName[];
static const char kTargetLanguagesKey[];
@@ -99,6 +103,9 @@ class TranslateLanguageList {
// fetch operation is finished.
Callback callback_;
+ // Counts how many times did it try to fetch the language list.
+ int retry_count_;
+
DISALLOW_COPY_AND_ASSIGN(LanguageListFetcher);
};
@@ -129,6 +136,9 @@ class TranslateLanguageList {
// language list.
scoped_ptr<LanguageListFetcher> alpha_language_list_fetcher_;
+ // Helper class to know if it's allowed to make network resource requests.
+ ResourceRequestAllowedNotifier resource_request_allowed_notifier_;
+
DISALLOW_COPY_AND_ASSIGN(TranslateLanguageList);
};

Powered by Google App Engine
This is Rietveld 408576698