Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 159490: Make the minimum extensions update frequency allowed on command line be 30 se... (Closed)

Created:
11 years, 4 months ago by asargent_no_longer_on_chrome
Modified:
9 years, 7 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, Ben Goodger (Google)
Visibility:
Public.

Description

Make the minimum extensions update frequency allowed on command line be 30 seconds. This is as opposed to the value of 1 hour in release mode, which makes testing difficult for people trying to test out autoupdate. BUG=http://crbug.com/17867 TEST=Run with --enable-extensions --extension-update-frequency=30 will actually update an extension that has updates after 30 seconds. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/extension_updater.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
asargent_no_longer_on_chrome
11 years, 4 months ago (2009-07-28 04:03:24 UTC) #1
Matt Perry
The comment claims that the limits are enforced only in release mode. Is that true? ...
11 years, 4 months ago (2009-07-28 16:22:42 UTC) #2
asargent_no_longer_on_chrome
11 years, 4 months ago (2009-07-28 16:30:44 UTC) #3
On 2009/07/28 16:22:42, Matt Perry wrote:
> The comment claims that the limits are enforced only in release mode. Is that
> true? If so, you shouldn't need this change. If not, change the comment.
> 
> Maybe you should wrap it in a #if _DEBUG; #else; so we don't forget to change
> this?

Actually the problem this CL addresses is that users of release builds on the
dev channel want to test out autoupdate, but right now are limited to only
having it run at most once an hour. I'd like for them to be able to run it as
often as every 30 seconds, so they can more easily test their update manifest
files and/or server side parsing of request parameters.

Powered by Google App Engine
This is Rietveld 408576698