Fix a case 'submatched_dict' may include a key with None value.

Fix a case 'submatched_dict' may include a key with None value.

BUG=None
NOTRY=True
TBR=peria@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202808

[Dai Mikurube (NOT FULLTIME), 2013-05-29 07:56:39]

Committed patchset #2 manually as r202808 (presubmit successful).

[Dai Mikurube (NOT FULLTIME), 2013-05-29 08:04:53]

Sorry for TBR.  It's a quick fix in the script.

[peria, 2013-05-29 08:13:08]

LGTM for quick fix.

However, please consider if Dump._map's elements (region_info[]) can have 'None'
in its values.

[Dai Mikurube (NOT FULLTIME), 2013-05-29 08:34:05]

Thanks!

I thought it doesn't happen since "submatched_dict.get(...)" is evaluated as
False if it's None in Python.  Tell me if it's wrong.
('vma' can have it looking at the script, but we can assume it doesn't happen.)

[peria, 2013-05-29 08:48:58]

On 2013/05/29 08:34:05, Dai Mikurube wrote:
> Thanks!
> 
> I thought it doesn't happen since "submatched_dict.get(...)" is evaluated as
> False if it's None in Python.  Tell me if it's wrong.
> ('vma' can have it looking at the script, but we can assume it doesn't
happen.)

Yes, it's true.
But if other routines can work with None values,
code can be less buggy and the routine in this CL can be simple.

(I'm not sure how dirty code "if not value:" branches can make ;)

[Dai Mikurube (NOT FULLTIME), 2013-05-29 08:58:08]

On 2013/05/29 08:48:58, peria wrote:
> On 2013/05/29 08:34:05, Dai Mikurube wrote:
> > Thanks!
> > 
> > I thought it doesn't happen since "submatched_dict.get(...)" is evaluated as
> > False if it's None in Python.  Tell me if it's wrong.
> > ('vma' can have it looking at the script, but we can assume it doesn't
> happen.)
> 
> Yes, it's true.
> But if other routines can work with None values,
> code can be less buggy and the routine in this CL can be simple.
> 
> (I'm not sure how dirty code "if not value:" branches can make ;)

Makes sense.  Ok, I'll try to fix it.  Thanks!
(The actual immediate problem here was that ".strip()" fails if
"submatched_dict['TYPE']" is None. We need this check in either case.)