Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Issue 159475: Merge 21608 - , INNTP: Adds 2 hard coded thumbnails.... (Closed)

Created:
11 years, 5 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
arv1
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Merge 21608 - , INNTP: Adds 2 hard coded thumbnails. This code needs to be rewritten after beta to handle localized content. BUG=15079 TEST=Start chrome with a new profile. There should be 2 thumbnails on the new tab page. Review URL: http://codereview.chromium.org/160126 TBR=arv@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21798

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -7 lines) Patch
MM chrome/app/generated_resources.grd View 1 chunk +11 lines, -1 line 0 comments Download
MM chrome/app/resources/locale_settings.grd View 1 chunk +10 lines, -2 lines 0 comments Download
MM chrome/app/theme/theme_resources.grd View 1 chunk +4 lines, -0 lines 0 comments Download
MM chrome/browser/dom_ui/new_tab_ui.cc View 7 chunks +71 lines, -2 lines 0 comments Download
MM chrome/browser/resources/new_new_tab.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
laforge
11 years, 5 months ago (2009-07-28 02:09:01 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698