Restore screen work area after login

Restore screen work area after login

When user login, a new virtual keyboard is created. If the old virtual keyboard
was showing before user login, we need to notfiy keyboard bounds observers that
old virtual keyboard window occupy no space on screen. Otherwise, Ash still thinks
the work area should exclude virtual keyboard area even the keyboard is not showing.
This CL fixed the bug.

BUG=342524
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250892

[bshe, 2014-02-11 01:19:27]

Hey Oshima.

Do you mind to take a look at this CL? Thanks!

Biao

[oshima, 2014-02-11 06:07:58]

lgtm

btw, when will we be able to not using work area change for VK?

[bshe, 2014-02-11 14:41:56]

On 2014/02/11 06:07:58, oshima wrote:
> lgtm
> 
> btw, when will we be able to not using work area change for VK?

Thanks for review.

It is probably gonna happen in M35. The issue is tracked here:
https://code.google.com/p/chromium/issues/detail?id=242933

[bshe, 2014-02-11 14:42:03]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2014-02-11 14:42:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/159473002/1

[oshima, 2014-02-11 18:19:04]

still lgtm

On 2014/02/11 14:41:56, bshe wrote:
> On 2014/02/11 06:07:58, oshima wrote:
> > lgtm
> > 
> > btw, when will we be able to not using work area change for VK?
> 
> Thanks for review.
> 
> It is probably gonna happen in M35. The issue is tracked here:
> https://code.google.com/p/chromium/issues/detail?id=242933

awesome, thanks!

[commit-bot: I haz the power, 2014-02-11 18:19:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-11 18:19:43]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[bshe, 2014-02-12 19:04:58]

Hi Kevin.

As discussed offline, do you mind to take a look at this? It should fix the
failing tests.

Thanks!

[kevers, 2014-02-12 20:05:24]

lgtm with nit.

https://codereview.chromium.org/159473002/diff/340001/ash/root_window_control...
File ash/root_window_controller_unittest.cc (right):

https://codereview.chromium.org/159473002/diff/340001/ash/root_window_control...
ash/root_window_controller_unittest.cc:668: aura::Window* root_window =
ash::Shell::GetPrimaryRootWindow();
Use of namespace should be consistent with above.

[bshe, 2014-02-12 21:09:48]

Done. Turns out that I need to make the HasKeyboardWindow virtual in order to
override it in some tests. Could you please take another look?

https://codereview.chromium.org/159473002/diff/340001/ash/root_window_control...
File ash/root_window_controller_unittest.cc (right):

https://codereview.chromium.org/159473002/diff/340001/ash/root_window_control...
ash/root_window_controller_unittest.cc:668: aura::Window* root_window =
ash::Shell::GetPrimaryRootWindow();
On 2014/02/12 20:05:24, kevers wrote:
> Use of namespace should be consistent with above.

Done.

[bshe, 2014-02-12 22:19:24]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2014-02-12 22:22:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/159473002/450001

[commit-bot: I haz the power, 2014-02-13 00:10:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 00:10:29]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[bshe, 2014-02-13 00:38:07]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2014-02-13 00:41:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/159473002/450001

[commit-bot: I haz the power, 2014-02-13 01:25:53]

Change committed as 250892