Issue 159471: Merge 21466 - Allow the browser to send actions back to the render for media ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159471: Merge 21466 - Allow the browser to send actions back to the render for media ... (Closed)

Created:
11 years, 4 months ago by laforge

Modified:
9 years, 6 months ago

Reviewers:
awong

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Description

Merge 21466 - Allow the browser to send actions back to the render for media element context menus. Also renamed ContextNodeType per fishd's suggestion. BUG=15686 TEST=none Review URL: http://codereview.chromium.org/155954 TBR=ajwong@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21789

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+351 lines, -104 lines)			Patch
MM	chrome/browser/renderer_host/render_view_host.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
MM	chrome/browser/renderer_host/render_view_host.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
MM	chrome/browser/tab_contents/render_view_context_menu.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
MM	chrome/browser/tab_contents/render_view_context_menu.cc	View	8 chunks	+110 lines, -29 lines	0 comments	Download
MM	chrome/browser/views/tab_contents/render_view_context_menu_external_win.h	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	chrome/browser/views/tab_contents/render_view_context_menu_win.h	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	chrome/common/render_messages.h	View	6 chunks	+52 lines, -12 lines	0 comments	Download
MM	chrome/common/render_messages_internal.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
MM	chrome/renderer/render_view.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
MM	chrome/renderer/render_view.cc	View	5 chunks	+13 lines, -2 lines	0 comments	Download
MM	webkit/glue/context_menu.h	View	6 chunks	+37 lines, -13 lines	0 comments	Download
MM	webkit/glue/context_menu_client_impl.cc	View	7 chunks	+39 lines, -36 lines	0 comments	Download
MM	webkit/glue/glue_util.h	View	3 chunks	+6 lines, -0 lines	0 comments	Download
MM	webkit/glue/glue_util.cc	View	3 chunks	+10 lines, -0 lines	0 comments	Download
MM	webkit/glue/webview.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
MM	webkit/glue/webview_delegate.h	View	3 chunks	+4 lines, -2 lines	0 comments	Download
MM	webkit/glue/webview_impl.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
MM	webkit/glue/webview_impl.cc	View	2 chunks	+36 lines, -0 lines	0 comments	Download
MM	webkit/tools/test_shell/test_webview_delegate.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
MM	webkit/tools/test_shell/test_webview_delegate.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages