Move application restart and relaunch code out of ExtensionService.

chrome/browser/extensions/unpacked_installer.h

Index: chrome/browser/extensions/unpacked_installer.h
diff --git a/chrome/browser/extensions/unpacked_installer.h b/chrome/browser/extensions/unpacked_installer.h
index d5964c5d4f22b82dbc91752b5f083d692148b85d..1d6dedc40c816d58d493824f57e86ee031acb419 100644
--- a/chrome/browser/extensions/unpacked_installer.h
+++ b/chrome/browser/extensions/unpacked_installer.h
@@ -39,11 +39,14 @@ class UnpackedInstaller
   void Load(const base::FilePath& extension_path);
 
   // Loads the extension from the directory |extension_path|;
-  // for use with command line switch --load-extension=path.
+  // for use with command line switch --load-extension=path or
+  // --load-and-launch-app.
   // This is equivalent to Load, except that it runs synchronously and
   // optionally launches the extension once it's loaded.

[koz (OOO until 15th September), 2013/05/30 00:22:22]

This function no longer optionally launches the extension once it's loaded so
this part of the comment is no longer valid. Also, it says that it runs
synchronously, but the new call site seems to behave as if it is asynchronous,
ie:

std::string extension_id;
LoadFromCommandLine(..., &extension_id);
ScheduleLaunchOnLoad(extension_id);  // Assumes extension_id not loaded yet.

It seems that it synchronously loads the extension off the disk, but
asynchronously "loads" the extension. Maybe just amend this comment by saying

"This is equivalent to Load, except that it reads the extension from
|extension_path| synchronously."

[benwells, 2013/05/30 01:47:43]

Done.

-  void LoadFromCommandLine(const base::FilePath& extension_path,
-                           bool launch_on_load);
+  // The return value indicates whether the installation has begun successfully.
+  // The id of the extension being loaded is returned in |extension_id|.
+  bool LoadFromCommandLine(const base::FilePath& extension_path,
+                           std::string* extension_id);
 
   // Allows prompting for plugins to be disabled; intended for testing only.
   bool prompt_for_plugins() { return prompt_for_plugins_; }
@@ -111,9 +114,6 @@ class UnpackedInstaller
   // version.
   bool require_modern_manifest_version_;
 
-  // Whether to launch the extension once it's loaded.
-  bool launch_on_load_;
-
   // Gives access to common methods and data of an extension installer.
   ExtensionInstaller installer_;