Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 159468: Merge 21595 - Partial fix to 7028 Pinning in Win7.A complete fix will requir... (Closed)

Created:
11 years, 5 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
brg
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Merge 21595 - Partial fix to 7028 Pinning in Win7.A complete fix will require Gears to set the application id as a property on the shortcut As of this cl, web applications hosted by Chrome will appear in their own groups on the task bar. However, they can not be pinned from the main application window nor can they be pinned from the shortcut. The former results in Chrome being pinned, and the latter results in a quick start button but does not group web applications under that button. Instead in the latter case a web appliation will form a new group. Bug=7028 Test=None. (When there is a Win7 trybot there may be at test to check if the windows group in the taskbar properly) Review URL: http://codereview.chromium.org/159336 TBR=brg@chromium.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21783

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
MM app/win_util.h View 1 chunk +5 lines, -0 lines 0 comments Download
MM app/win_util.cc View 4 chunks +54 lines, -0 lines 0 comments Download
MM chrome/browser/browser.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 5 months ago (2009-07-28 01:18:48 UTC) #1
brg_google.com
11 years, 4 months ago (2009-07-28 17:30:23 UTC) #2
LGTM.  Please merge in http://codereview.chromium.org/160150 as well
as it has a COM usage fix.


On Mon, Jul 27, 2009 at 6:18 PM, <laforge@chromium.org> wrote:
>
> Reviewers: brg,
>
> Description:
> Merge 21595 - Partial fix to 7028 =A0Pinning in Win7.A complete fix will
> require Gears to set the application id as a property on the shortcut
> As of this cl, web applications hosted by Chrome will appear in their
> own groups on the task bar. =A0However, they can not be pinned from the
> main application window nor can they be pinned from the shortcut. =A0The
> former results in Chrome being pinned, and the latter results in a quick
> start button but does not group web applications under that button.
> Instead in the latter case a web appliation will form a new group.
>
> Bug=3D7028
> Test=3DNone. =A0(When there is a Win7 trybot there may be at test to chec=
k
> if the windows group in the taskbar properly)
> Review URL: http://codereview.chromium.org/159336
>
> TBR=3Dbrg@chromium.com
>
>
> Please review this at http://codereview.chromium.org/159468
>
> SVN Base: svn://chrome-svn/chrome/branches/195/src/
>
> Affected files:
> =A0MM =A0 =A0app/win_util.h
> =A0MM =A0 =A0app/win_util.cc
> =A0MM =A0 =A0chrome/browser/browser.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698