Issue 159463004: Packing/unpacking of width and height in gfx::Size is redundant while using CreateJavaBitmap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159463004: Packing/unpacking of width and height in gfx::Size is redundant while using CreateJavaBitmap. (Closed)

Created:
6 years, 10 months ago by vivekg_samsung

Modified:
6 years, 10 months ago

Reviewers:
danakj, vivekg

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Packing/unpacking of width and height in gfx::Size is redundant while using CreateJavaBitmap. We pack width/height in ConvertToJavaBitmap into gfx::Size to be unpacked in CreateJavaBitmap while calling the BitmapHelper.createBitmap method from Java. This is not needed and should be called directly using width and height as is. R=danakj Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250916

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	ui/gfx/android/java_bitmap.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/159463004/1

6 years, 10 months ago (2014-02-12 17:06:17 UTC) #4

Message was sent while issue was closed.

Change committed as 250916

Expand Messages | Collapse Messages