android envsetup: Stop exporting (and honoring) ANDROID_SDK_VERSION.

android envsetup: Stop exporting (and honoring) ANDROID_SDK_VERSION.

If someone wants to use a custom android sdk version, they now need to set
the android_sdk_version gyp define instead of this env var.

(Depends on one internal change to an internal bot that currently sets the
env var: https://chrome-internal-review.googlesource.com/154255)

BUG=330631
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251354

[Nico, 2014-02-11 01:13:45]

https://codereview.chromium.org/159463002/diff/1/build/android/envsetup_funct...
File build/android/envsetup_functions.sh (right):

https://codereview.chromium.org/159463002/diff/1/build/android/envsetup_funct...
build/android/envsetup_functions.sh:155: android_sdk_version=18
Is this intentionally less than what the sdk build uses?

[Torne, 2014-02-11 10:43:50]

https://codereview.chromium.org/159463002/diff/1/build/android/envsetup_funct...
File build/android/envsetup_functions.sh (right):

https://codereview.chromium.org/159463002/diff/1/build/android/envsetup_funct...
build/android/envsetup_functions.sh:155: android_sdk_version=18
On 2014/02/11 01:13:45, Nico (away Feb 11 - Feb 17) wrote:
> Is this intentionally less than what the sdk build uses?

No, it's just not been updated. It doesn't matter very much as we don't link
against the SDK framework jar; we just use a couple of tools out of it. I would
like to completely remove all references to the NDK and SDK from the WebView
build, but haven't been able to do this yet.

[Nico, 2014-02-13 23:16:55]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-02-13 23:20:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 23:20:17]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Nico, 2014-02-13 23:27:29]

Heh, looks like you didn't lgtm this. Any reason, or did you just forget?

https://codereview.chromium.org/159463002/diff/1/build/android/envsetup_funct...
File build/android/envsetup_functions.sh (right):

https://codereview.chromium.org/159463002/diff/1/build/android/envsetup_funct...
build/android/envsetup_functions.sh:155: android_sdk_version=18
On 2014/02/11 10:43:51, Torne wrote:
> On 2014/02/11 01:13:45, Nico (away Feb 11 - Feb 17) wrote:
> > Is this intentionally less than what the sdk build uses?
> 
> No, it's just not been updated. It doesn't matter very much as we don't link
> against the SDK framework jar; we just use a couple of tools out of it. I
would
> like to completely remove all references to the NDK and SDK from the WebView
> build, but haven't been able to do this yet.

Oh cool. For now, if it doesn't matter much, should this line just be deleted so
that the webview build uses the same sdk version as the non-webview android
build? (Not necessarily in this CL.)

Also, since you say the webview build doesn't use the ndk in
https://codereview.chromium.org/11886053/ , I suppose the ANDROID_NDK_ROOT line
can go away too?

[Torne, 2014-02-14 10:47:48]

On 2014/02/13 23:27:29, Nico (away Feb 11 - Feb 17) wrote:
> Heh, looks like you didn't lgtm this. Any reason, or did you just forget?
> 
>
https://codereview.chromium.org/159463002/diff/1/build/android/envsetup_funct...
> File build/android/envsetup_functions.sh (right):
> 
>
https://codereview.chromium.org/159463002/diff/1/build/android/envsetup_funct...
> build/android/envsetup_functions.sh:155: android_sdk_version=18
> On 2014/02/11 10:43:51, Torne wrote:
> > On 2014/02/11 01:13:45, Nico (away Feb 11 - Feb 17) wrote:
> > > Is this intentionally less than what the sdk build uses?
> > 
> > No, it's just not been updated. It doesn't matter very much as we don't link
> > against the SDK framework jar; we just use a couple of tools out of it. I
> would
> > like to completely remove all references to the NDK and SDK from the WebView
> > build, but haven't been able to do this yet.
> 
> Oh cool. For now, if it doesn't matter much, should this line just be deleted
so
> that the webview build uses the same sdk version as the non-webview android
> build? (Not necessarily in this CL.)

Should be fine.

> Also, since you say the webview build doesn't use the ndk in
> https://codereview.chromium.org/11886053/ , I suppose the ANDROID_NDK_ROOT
line
> can go away too?

If doing so doesn't break the android_aosp build, then yes. I am not certain
that we don't depend on this right now; I thought we had intentionally set it to
a fake value to catch uses, but I guess not, so there may accidentally be
dependencies there somewhere?

LGTM

[Nico, 2014-02-14 14:31:26]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-02-14 14:31:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/159463002/1

[commit-bot: I haz the power, 2014-02-14 16:59:53]

Change committed as 251354