Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15946006: Move C++ code from webkit/tools/test_shell to webkit/support (Closed)

Created:
7 years, 7 months ago by jamesr
Modified:
7 years, 6 months ago
CC:
chromium-reviews, jam, sail+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dcheng, jochen+watch_chromium.org
Visibility:
Public.

Description

Move C++ code from webkit/tools/test_shell to webkit/support This code is simple/test/mock implementations of APIs to use in DumpRenderTree, webkit_unit_tests, and various other bits of unit test code around the codebase. Nothing here is used for test_shell since there is no test_shell any more. This moves the code to webkit/support/ along with the rest of DRT/w_u_t support code. Hopefully we'll be able to delete most of this soon along with DumpRenderTree. In the meantime this simplifies webkit/ R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203242 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204005

Patch Set 1 #

Patch Set 2 : attempt to fix paths in webkit_plugins.gypi #

Patch Set 3 : fix test_shell dummy target #

Patch Set 4 : fix android_webview license check #

Patch Set 5 : rebased #

Patch Set 6 : rebased better #

Patch Set 7 : fix gyp cycles #

Patch Set 8 : fix test_mock_plugin_list #

Patch Set 9 : fix npapi_test_plugin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+395 lines, -4951 lines) Patch
M android_webview/tools/third_party_files_whitelist.txt View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/content_plugin.gypi View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/shell_content_renderer_client.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
A webkit/plugins/webkit_plugins.gyp View 1 2 3 4 5 6 7 8 1 chunk +246 lines, -0 lines 0 comments Download
M webkit/plugins/webkit_plugins.gypi View 1 2 3 4 5 6 4 chunks +3 lines, -77 lines 0 comments Download
A + webkit/support/mac/DumpRenderTreePasteboard.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/support/mac/DumpRenderTreePasteboard.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/support/mock_webclipboard_impl.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/support/mock_webclipboard_impl.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/platform_support_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/platform_support_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + webkit/support/simple_appcache_system.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/support/simple_appcache_system.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + webkit/support/simple_clipboard_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/support/simple_clipboard_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/support/simple_dom_storage_system.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/support/simple_dom_storage_system.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A + webkit/support/simple_file_system.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/support/simple_file_system.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
A + webkit/support/simple_file_writer.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/support/simple_file_writer.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
A + webkit/support/simple_resource_loader_bridge.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/support/simple_resource_loader_bridge.cc View 1 2 3 4 5 6 2 chunks +7 lines, -7 lines 0 comments Download
A + webkit/support/simple_socket_stream_bridge.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/support/simple_socket_stream_bridge.cc View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/support/simple_webcookiejar_impl.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/support/simple_webcookiejar_impl.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
A + webkit/support/test_shell_dummy.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/support/test_shell_request_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/support/test_shell_request_context.cc View 1 2 3 4 5 6 2 chunks +4 lines, -5 lines 0 comments Download
A + webkit/support/test_shell_webblobregistry_impl.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/support/test_shell_webblobregistry_impl.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A + webkit/support/test_shell_webmimeregistry_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/support/test_shell_webmimeregistry_impl.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/test_webkit_platform_support.h View 1 2 3 4 5 6 1 chunk +6 lines, -6 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 2 3 4 5 6 1 chunk +8 lines, -8 lines 0 comments Download
M webkit/support/webkit_support.cc View 1 2 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 2 3 4 5 6 2 chunks +26 lines, -26 lines 0 comments Download
D webkit/tools/test_shell/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D webkit/tools/test_shell/mac/DumpRenderTreePasteboard.h View 1 chunk +0 lines, -46 lines 0 comments Download
D webkit/tools/test_shell/mac/DumpRenderTreePasteboard.m View 1 chunk +0 lines, -214 lines 0 comments Download
D webkit/tools/test_shell/mock_webclipboard_impl.h View 1 2 3 4 5 6 1 chunk +0 lines, -60 lines 0 comments Download
D webkit/tools/test_shell/mock_webclipboard_impl.cc View 1 2 3 4 5 6 1 chunk +0 lines, -207 lines 0 comments Download
D webkit/tools/test_shell/simple_appcache_system.h View 1 chunk +0 lines, -136 lines 0 comments Download
D webkit/tools/test_shell/simple_appcache_system.cc View 1 chunk +0 lines, -465 lines 0 comments Download
D webkit/tools/test_shell/simple_clipboard_impl.h View 1 chunk +0 lines, -43 lines 0 comments Download
D webkit/tools/test_shell/simple_clipboard_impl.cc View 1 chunk +0 lines, -118 lines 0 comments Download
D webkit/tools/test_shell/simple_dom_storage_system.h View 1 2 3 4 5 6 1 chunk +0 lines, -79 lines 0 comments Download
D webkit/tools/test_shell/simple_dom_storage_system.cc View 1 2 3 4 5 6 1 chunk +0 lines, -286 lines 0 comments Download
D webkit/tools/test_shell/simple_file_system.h View 1 2 3 4 5 6 1 chunk +0 lines, -160 lines 0 comments Download
D webkit/tools/test_shell/simple_file_system.cc View 1 2 3 4 5 6 1 chunk +0 lines, -410 lines 0 comments Download
D webkit/tools/test_shell/simple_file_writer.h View 1 2 3 4 1 chunk +0 lines, -53 lines 0 comments Download
D webkit/tools/test_shell/simple_file_writer.cc View 1 2 3 4 5 6 1 chunk +0 lines, -205 lines 0 comments Download
D webkit/tools/test_shell/simple_resource_loader_bridge.h View 1 chunk +0 lines, -61 lines 0 comments Download
D webkit/tools/test_shell/simple_resource_loader_bridge.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1168 lines 0 comments Download
D webkit/tools/test_shell/simple_socket_stream_bridge.h View 1 chunk +0 lines, -35 lines 0 comments Download
D webkit/tools/test_shell/simple_socket_stream_bridge.cc View 1 2 3 4 5 6 1 chunk +0 lines, -259 lines 0 comments Download
D webkit/tools/test_shell/simple_webcookiejar_impl.h View 1 2 3 4 5 6 1 chunk +0 lines, -22 lines 0 comments Download
D webkit/tools/test_shell/simple_webcookiejar_impl.cc View 1 2 3 4 5 6 1 chunk +0 lines, -25 lines 0 comments Download
D webkit/tools/test_shell/test_shell.gypi View 1 chunk +0 lines, -198 lines 0 comments Download
D webkit/tools/test_shell/test_shell_dummy.cc View 1 chunk +0 lines, -7 lines 0 comments Download
D webkit/tools/test_shell/test_shell_request_context.h View 1 chunk +0 lines, -56 lines 0 comments Download
D webkit/tools/test_shell/test_shell_request_context.cc View 1 2 3 4 5 6 1 chunk +0 lines, -141 lines 0 comments Download
D webkit/tools/test_shell/test_shell_webblobregistry_impl.h View 1 2 3 4 5 6 1 chunk +0 lines, -49 lines 0 comments Download
D webkit/tools/test_shell/test_shell_webblobregistry_impl.cc View 1 2 3 4 5 6 1 chunk +0 lines, -124 lines 0 comments Download
D webkit/tools/test_shell/test_shell_webmimeregistry_impl.h View 1 chunk +0 lines, -45 lines 0 comments Download
D webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc View 1 2 3 4 5 6 1 chunk +0 lines, -70 lines 0 comments Download
M webkit/webkit.gyp View 1 2 3 4 5 6 2 chunks +24 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jamesr
After this patch, webkit/tools/ contains some scripts for layout tests and some resource files that ...
7 years, 7 months ago (2013-05-24 22:13:08 UTC) #1
darin (slow to review)
LGTM
7 years, 6 months ago (2013-05-28 20:42:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/15946006/25001
7 years, 6 months ago (2013-05-28 22:40:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/15946006/31001
7 years, 6 months ago (2013-05-28 22:56:37 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=5428
7 years, 6 months ago (2013-05-28 23:06:14 UTC) #5
jamesr
Committed patchset #6 manually as r203242 (presubmit successful).
7 years, 6 months ago (2013-05-30 22:26:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/15946006/43046
7 years, 6 months ago (2013-06-04 16:52:09 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=6660
7 years, 6 months ago (2013-06-04 17:02:08 UTC) #8
jamesr
7 years, 6 months ago (2013-06-04 18:12:51 UTC) #9
Message was sent while issue was closed. 
Committed patchset #9 manually as r204005 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698