Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: Source/core/rendering/RenderBox.cpp

Issue 15946003: Don't stretch margin: auto items in a vertical flexbox (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/css3/flexbox/columns-center-with-margins-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderBox.cpp
diff --git a/Source/core/rendering/RenderBox.cpp b/Source/core/rendering/RenderBox.cpp
index 747528e6a35f7bfebec806bbb570a3990b21849a..68af030db0396a7c9d084b607b80e70f66400d87 100644
--- a/Source/core/rendering/RenderBox.cpp
+++ b/Source/core/rendering/RenderBox.cpp
@@ -2229,6 +2229,10 @@ bool RenderBox::sizesLogicalWidthToFitContent(SizeType widthType) const
return true;
if (!flexItemHasStretchAlignment(this))
return true;
+ if (parent()->style()->isColumnFlexDirection() && (style()->marginLeft().isAuto() || style()->marginRight().isAuto())) {
+ // Auto margins means we want centering, not stretching, so we want to return true here
+ return true;
+ }
}
// Flexible horizontal boxes lay out children at their intrinsic widths. Also vertical boxes
« no previous file with comments | « LayoutTests/css3/flexbox/columns-center-with-margins-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698