Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2046)

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 15946002: Allow breakpoints on strict equal (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/flow_graph_inliner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_x64.cc
===================================================================
--- runtime/vm/flow_graph_compiler_x64.cc (revision 23151)
+++ runtime/vm/flow_graph_compiler_x64.cc (working copy)
@@ -1437,7 +1437,8 @@
void FlowGraphCompiler::EmitEqualityRegConstCompare(Register reg,
const Object& obj,
- bool needs_number_check) {
+ bool needs_number_check,
+ intptr_t token_pos) {
if (needs_number_check) {
if (!obj.IsMint() && !obj.IsDouble() && !obj.IsBigint()) {
needs_number_check = false;
@@ -1454,6 +1455,9 @@
__ pushq(reg);
__ PushObject(obj);
__ call(&StubCode::IdenticalWithNumberCheckLabel());
+ AddCurrentDescriptor(PcDescriptors::kRuntimeCall,
+ Isolate::kNoDeoptId,
+ token_pos);
__ popq(reg); // Discard constant.
__ popq(reg); // Restore 'reg'.
return;
@@ -1465,11 +1469,15 @@
void FlowGraphCompiler::EmitEqualityRegRegCompare(Register left,
Register right,
- bool needs_number_check) {
+ bool needs_number_check,
+ intptr_t token_pos) {
if (needs_number_check) {
__ pushq(left);
__ pushq(right);
__ call(&StubCode::IdenticalWithNumberCheckLabel());
+ AddCurrentDescriptor(PcDescriptors::kRuntimeCall,
+ Isolate::kNoDeoptId,
+ token_pos);
// Stub returns result in flags (result of a cmpl, we need ZF computed).
__ popq(right);
__ popq(left);
« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/flow_graph_inliner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698