Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 15946002: Allow breakpoints on strict equal (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_compiler_ia32.cc
===================================================================
--- runtime/vm/flow_graph_compiler_ia32.cc (revision 23094)
+++ runtime/vm/flow_graph_compiler_ia32.cc (working copy)
@@ -1440,7 +1440,8 @@
void FlowGraphCompiler::EmitEqualityRegConstCompare(Register reg,
const Object& obj,
- bool needs_number_check) {
+ bool needs_number_check,
+ intptr_t token_pos) {
if (needs_number_check) {
if (!obj.IsMint() && !obj.IsDouble() && !obj.IsBigint()) {
needs_number_check = false;
@@ -1457,6 +1458,9 @@
__ pushl(reg);
__ PushObject(obj);
__ call(&StubCode::IdenticalWithNumberCheckLabel());
+ AddCurrentDescriptor(PcDescriptors::kRuntimeCall,
+ Isolate::kNoDeoptId,
+ token_pos);
__ popl(reg); // Discard constant.
__ popl(reg); // Restore 'reg'.
return;
@@ -1468,11 +1472,15 @@
void FlowGraphCompiler::EmitEqualityRegRegCompare(Register left,
Register right,
- bool needs_number_check) {
+ bool needs_number_check,
+ intptr_t token_pos) {
if (needs_number_check) {
__ pushl(left);
__ pushl(right);
__ call(&StubCode::IdenticalWithNumberCheckLabel());
+ AddCurrentDescriptor(PcDescriptors::kRuntimeCall,
+ Isolate::kNoDeoptId,
+ token_pos);
// Stub returns result in flags (result of a cmpl, we need ZF computed).
__ popl(right);
__ popl(left);

Powered by Google App Engine
This is Rietveld 408576698