Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1740)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 15946002: Allow breakpoints on strict equal (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 23094)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -1397,7 +1397,8 @@
ConstantInstr* zero = flow_graph()->GetConstant(Smi::Handle(Smi::New(0)));
StrictCompareInstr* compare =
- new StrictCompareInstr(Token::kEQ_STRICT,
+ new StrictCompareInstr(call->token_pos(),
+ Token::kEQ_STRICT,
new Value(load),
new Value(zero));
ReplaceCall(call, compare);
@@ -2607,7 +2608,8 @@
Token::Kind strict_kind = (compare->kind() == Token::kEQ) ?
Token::kEQ_STRICT : Token::kNE_STRICT;
StrictCompareInstr* strict_comp =
- new StrictCompareInstr(strict_kind,
+ new StrictCompareInstr(compare->token_pos(),
+ strict_kind,
compare->left()->CopyWithType(),
compare->right()->CopyWithType());
current_instruction->ReplaceWith(strict_comp, current_iterator());
@@ -5992,7 +5994,10 @@
ComparisonInstr* comparison = branch->comparison();
ComparisonInstr* new_comparison = NULL;
if (comparison->IsStrictCompare()) {
- new_comparison = new StrictCompareInstr(comparison->kind(), left, right);
+ new_comparison = new StrictCompareInstr(comparison->token_pos(),
+ comparison->kind(),
+ left,
+ right);
} else if (comparison->IsEqualityCompare()) {
EqualityCompareInstr* equality_compare = comparison->AsEqualityCompare();
EqualityCompareInstr* new_equality_compare =

Powered by Google App Engine
This is Rietveld 408576698