Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 159459: Workaround for GtkFileChooserButton bug: disable mouse wheel scrolling.... (Closed)

Created:
11 years, 5 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
Evan Martin, mattm
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Workaround for GtkFileChooserButton bug: disable mouse wheel scrolling. Also disable it for the cookie behavior combobox, because it fights with the scrolled window. The GtkFileChooserButton spews the following 2 errors (and possibly others) when you scroll on it quickly: Gtk-WARNING **: idle activate multiple times without clearing the folder object first. Gtk: gtk_tree_model_get_iter: assertion `path != NULL' failed This causes us to crash in debug, and causes undesirable console output in release. I verified that this is their bug and not ours by reproing in a simple program that just has a window with a GtkFileChooserButton in it. BUG=17805 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M chrome/browser/gtk/options/advanced_contents_gtk.cc View 3 chunks +40 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Stade
11 years, 5 months ago (2009-07-28 00:38:06 UTC) #1
mattm
On 2009/07/28 00:38:06, Evan Stade wrote: > lgtm The scroll wheel on those comboboxes was ...
11 years, 5 months ago (2009-07-28 00:50:45 UTC) #2
Evan Stade
11 years, 5 months ago (2009-07-28 01:08:30 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698