Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 159453002: Revert of Fix an errant pylint change. (Closed)

Created:
6 years, 10 months ago by jbudorick
Modified:
6 years, 10 months ago
Reviewers:
craigdh, cjhopman, frankf
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Fix an errant pylint change. (https://codereview.chromium.org/143623007/) Reason for revert: crbug.com/342539 is likely happening because of the patch that this patch depends on. I need to ensure that logcats work on the bots before relanding (and that the corresponding steps fail if they don't.) Original issue's description: > I broke something by removing an apparently unused import that actually was used elsewhere. I addressed the issue by having the client code just call android_commands.GetAttachedDevices explicitly. > > BUG=168518 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250206 TBR=craigdh@chromium.org,frankf@chromium.org,cjhopman@chromium.org NOTREECHECKS=true NOTRY=true BUG=168518 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250264

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/PRESUBMIT.py View 1 chunk +2 lines, -0 lines 0 comments Download
M build/android/gyp/util/build_device.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jbudorick
Created Revert of Fix an errant pylint change.
6 years, 10 months ago (2014-02-11 01:09:46 UTC) #1
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-11 01:12:40 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-11 01:12:41 UTC) #3
craigdh
lgtm.
6 years, 10 months ago (2014-02-11 01:13:33 UTC) #4
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 10 months ago (2014-02-11 01:13:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/159453002/1
6 years, 10 months ago (2014-02-11 01:16:24 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 01:20:35 UTC) #7
Message was sent while issue was closed.
Change committed as 250264

Powered by Google App Engine
This is Rietveld 408576698