Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: runtime/vm/simulator_arm.cc

Issue 15945006: Fix leaf floating point runtime calls on ARM (work still needed in simulator). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/simulator_arm.h ('k') | tests/language/language.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/simulator_arm.cc
===================================================================
--- runtime/vm/simulator_arm.cc (revision 23505)
+++ runtime/vm/simulator_arm.cc (working copy)
@@ -1494,12 +1494,13 @@
set_register(R3, icount_);
set_register(IP, icount_);
set_register(LR, icount_);
- float zap_fvalue = static_cast<float>(icount_);
- for (int i = S0; i <= S15; i++) {
- set_sregister(static_cast<SRegister>(i), zap_fvalue);
+ double zap_dvalue = static_cast<double>(icount_);
+ for (int i = D0; i <= D7; i++) {
+ set_dregister(static_cast<DRegister>(i), zap_dvalue);
}
+ // The above loop also zaps overlapping registers S0-S15.
+ // Registers D8-D15 (overlapping with S16-S31) are preserved.
#ifdef VFPv3_D32
- double zap_dvalue = static_cast<double>(icount_);
for (int i = D16; i <= D31; i++) {
set_dregister(static_cast<DRegister>(i), zap_dvalue);
}
« no previous file with comments | « runtime/vm/simulator_arm.h ('k') | tests/language/language.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698