Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 159445: Merge 21445 - Close pop up notification when navigating to other site.... (Closed)

Created:
11 years, 5 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
erg
CC:
chromium-reviews_googlegroups.com, brettw, Ben Goodger (Google)
Visibility:
Public.

Description

Merge 21445 - Close pop up notification when navigating to other site. When BlockedPopupContainer stopped being a ConstrainedWindow, the notification stopped being cleared in TabContents::MaybeCloseChildWindows. http://crbug.com/8622 http://crbug.com/14150 TEST=See 8622 for repro steps. Review URL: http://codereview.chromium.org/159287 TBR=erg@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
MM chrome/browser/tab_contents/tab_contents.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 5 months ago (2009-07-27 22:58:32 UTC) #1
erg
11 years, 5 months ago (2009-07-27 23:00:07 UTC) #2
Horray! LGTM.

On Mon, Jul 27, 2009 at 3:58 PM, <laforge@chromium.org> wrote:
> Reviewers: erg,
>
> Description:
> Merge 21445 - Close pop up notification when navigating to other site.
>
> When BlockedPopupContainer stopped being a ConstrainedWindow, the
> notification stopped being cleared in
> TabContents::MaybeCloseChildWindows.
>
> http://crbug.com/8622
> http://crbug.com/14150
> TEST=3DSee 8622 for repro steps.
>
> Review URL: http://codereview.chromium.org/159287
>
> TBR=3Derg@google.com
>
>
> Please review this at http://codereview.chromium.org/159445
>
> SVN Base: svn://chrome-svn/chrome/branches/195/src/
>
> Affected files:
> =A0MM =A0 =A0chrome/browser/tab_contents/tab_contents.cc
>
>
> Index: chrome/browser/tab_contents/tab_contents.cc
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- chrome/browser/tab_contents/tab_contents.cc (revision 21732)
> +++ chrome/browser/tab_contents/tab_contents.cc (working copy)
> @@ -1264,6 +1264,12 @@
> =A0 =A0 if (window)
> =A0 =A0 =A0 window->CloseConstrainedWindow();
> =A0 }
> +
> + =A0// Close the popup container.
> + =A0if (blocked_popups_) {
> + =A0 =A0blocked_popups_->Destroy();
> + =A0 =A0blocked_popups_ =3D NULL;
> + =A0}
> =A0}
>
> =A0void TabContents::UpdateStarredStateForCurrentURL() {
>
> Property changes on: chrome\browser\tab_contents\tab_contents.cc
> ___________________________________________________________________
> Modified: svn:mergeinfo
> =A0 Merged /trunk/src/chrome/browser/tab_contents/tab_contents.cc:r21445
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698