Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Issue 1594313002: Create a public interface for AST nodes and rename the implementation classes (Closed)

Created:
4 years, 11 months ago by Brian Wilkerson
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create a public interface for AST nodes and rename the implementation classes R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/6f56368747983295ad378a063dca278488a4d5f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9146 lines, -2641 lines) Patch
A pkg/analyzer/lib/dart/ast/ast.dart View 1 chunk +7985 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/dart/ast/visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 401 chunks +1116 lines, -2639 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 2 chunks +44 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Next steps are to move the impl classes into a permanent location and then update ...
4 years, 11 months ago (2016-01-17 23:43:24 UTC) #2
scheglov
LGTM
4 years, 11 months ago (2016-01-18 17:24:47 UTC) #3
Brian Wilkerson
4 years, 11 months ago (2016-01-18 17:53:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6f56368747983295ad378a063dca278488a4d5f6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698